JIT: Fix infinite loop in copy prop GT_COMMA update logic (#105196)

jakobbotsch · web-flow · commit 18b2ef18fd58 · 2024-07-21T18:35:05.000+02:00
diff --git a/src/coreclr/jit/copyprop.cpp b/src/coreclr/jit/copyprop.cpp
@@ -296,7 +296,7 @@ bool Compiler::optCopyProp(
                 JITDUMP(" Updating COMMA parent VN [%06u]\n", dspTreeID(parent));
                 ValueNumPair op1Xvnp = vnStore->VNPExceptionSet(parent->AsOp()->gtOp1->gtVNPair);
                 parent->SetVNs(vnStore->VNPWithExc(parent->AsOp()->gtOp2->gtVNPair, op1Xvnp));
-                parent = tree->gtGetParent(nullptr);
+                parent = parent->gtGetParent(nullptr);
             }
         }
         gtUpdateSideEffects(stmt, tree);

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ bool Compiler::optCopyProp(`
`296`	`296`	`JITDUMP(" Updating COMMA parent VN [%06u]\n", dspTreeID(parent));`
`297`	`297`	`ValueNumPair op1Xvnp = vnStore->VNPExceptionSet(parent->AsOp()->gtOp1->gtVNPair);`
`298`	`298`	`parent->SetVNs(vnStore->VNPWithExc(parent->AsOp()->gtOp2->gtVNPair, op1Xvnp));`
`299`		`- parent = tree->gtGetParent(nullptr);`
	`299`	`+ parent = parent->gtGetParent(nullptr);`
`300`	`300`	`}`
`301`	`301`	`}`
`302`	`302`	`gtUpdateSideEffects(stmt, tree);`