Skip to content

Commit 12aaae4

Browse files
Fix createdump arg parsing for signal-based exceptions (#85423)
Co-authored-by: Juan Sebastian Hoyos Ayala <juan.s.hoyos@outlook.com>
1 parent 3a80b29 commit 12aaae4

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/coreclr/debug/createdump/createdump.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ typedef struct
100100
int Pid;
101101
int CrashThread;
102102
int Signal;
103-
#if defined(HOST_UNIX) && !defined(HOST_OSX)
103+
#if defined(HOST_UNIX)
104104
int SignalCode;
105105
int SignalErrno;
106106
void* SignalAddress;

src/coreclr/debug/createdump/main.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ int __cdecl main(const int argc, const char* argv[])
7070
options.Signal = 0;
7171
options.CrashThread = 0;
7272
options.Pid = 0;
73-
#if defined(HOST_UNIX) && !defined(HOST_OSX)
73+
#if defined(HOST_UNIX)
7474
options.SignalCode = 0;
7575
options.SignalErrno = 0;
7676
options.SignalAddress = nullptr;
@@ -161,7 +161,6 @@ int __cdecl main(const int argc, const char* argv[])
161161
{
162162
g_checkForSingleFile = true;
163163
}
164-
#ifndef HOST_OSX
165164
else if (strcmp(*argv, "--code") == 0)
166165
{
167166
options.SignalCode = atoi(*++argv);
@@ -174,7 +173,6 @@ int __cdecl main(const int argc, const char* argv[])
174173
{
175174
options.SignalAddress = (void*)atoll(*++argv);
176175
}
177-
#endif
178176
#endif
179177
else if ((strcmp(*argv, "-d") == 0) || (strcmp(*argv, "--diag") == 0))
180178
{

0 commit comments

Comments
 (0)