Skip to content

Commit 0eb7a82

Browse files
committed
Log error for SPC
1 parent 73ede46 commit 0eb7a82

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/coreclr/tools/aot/ILCompiler.Build.Tasks/ComputeManagedAssembliesToCompileToNative.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,18 @@ public override bool Execute()
160160
// Currently that's System.Private.* SDK assemblies and a bunch of framework assemblies.
161161
if (nativeAotFrameworkAssembliesToUse.TryGetValue(assemblyFileName, out ITaskItem frameworkItem))
162162
{
163+
Console.WriteLine("warning: Found {0} in {1}", assemblyFileName, frameworkItem.ItemSpec);
163164
if (GetFileVersion(itemSpec).CompareTo(GetFileVersion(frameworkItem.ItemSpec)) > 0)
164165
{
165-
// Allow OOB references with higher version to take precedence over the framework assemblies.
166-
list.Add(taskItem);
166+
if (assemblyFileName == "System.Private.CoreLib.dll")
167+
{
168+
Log.LogError($"Overriding System.Private.CoreLib.dll with a newer version is not supported. Attempted to use {itemSpec} instead of {frameworkItem.ItemSpec}.");
169+
}
170+
else
171+
{
172+
// Allow OOB references with higher version to take precedence over the framework assemblies.
173+
list.Add(taskItem);
174+
}
167175
}
168176

169177
assembliesToSkipPublish.Add(taskItem);

0 commit comments

Comments
 (0)