Skip to content

Commit 0c419b0

Browse files
Delete finally blocks in EcmaSignatureParser (#85577)
These lightweight structs are not meant to be reusable.
1 parent e56ff52 commit 0c419b0

File tree

1 file changed

+11
-28
lines changed

1 file changed

+11
-28
lines changed

src/coreclr/tools/Common/TypeSystem/Ecma/EcmaSignatureParser.cs

Lines changed: 11 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -327,19 +327,10 @@ public bool IsFieldSignature
327327

328328
public MethodSignature ParseMethodSignature()
329329
{
330-
try
331-
{
332-
_indexStack = new Stack<int>();
333-
_indexStack.Push(0);
334-
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
335-
return ParseMethodSignatureInternal(skipEmbeddedSignatureData: false);
336-
}
337-
finally
338-
{
339-
_indexStack = null;
340-
_embeddedSignatureDataList = null;
341-
}
342-
330+
_indexStack = new Stack<int>();
331+
_indexStack.Push(0);
332+
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
333+
return ParseMethodSignatureInternal(skipEmbeddedSignatureData: false);
343334
}
344335

345336
private MethodSignature ParseMethodSignatureInternal(bool skipEmbeddedSignatureData)
@@ -473,21 +464,13 @@ public TypeDesc ParseFieldSignature()
473464

474465
public TypeDesc ParseFieldSignature(out EmbeddedSignatureData[] embeddedSigData)
475466
{
476-
try
477-
{
478-
_indexStack = new Stack<int>();
479-
_indexStack.Push(1);
480-
_indexStack.Push(0);
481-
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
482-
TypeDesc parsedType = ParseFieldSignature();
483-
embeddedSigData = _embeddedSignatureDataList.Count == 0 ? null : _embeddedSignatureDataList.ToArray();
484-
return parsedType;
485-
}
486-
finally
487-
{
488-
_indexStack = null;
489-
_embeddedSignatureDataList = null;
490-
}
467+
_indexStack = new Stack<int>();
468+
_indexStack.Push(1);
469+
_indexStack.Push(0);
470+
_embeddedSignatureDataList = new List<EmbeddedSignatureData>();
471+
TypeDesc parsedType = ParseFieldSignature();
472+
embeddedSigData = _embeddedSignatureDataList.Count == 0 ? null : _embeddedSignatureDataList.ToArray();
473+
return parsedType;
491474
}
492475

493476
public LocalVariableDefinition[] ParseLocalsSignature()

0 commit comments

Comments
 (0)