Disable distributed transaction tests on ARM (#74573)

github-actions[bot] · roji · web-flow · commit 0969048555c1 · 2022-08-25T09:00:38.000-07:00
To unblock CI build failures, works around #74170 Co-authored-by: Shay Rojansky <roji@roji.org>
diff --git a/src/libraries/System.Transactions.Local/tests/OleTxTests.cs b/src/libraries/System.Transactions.Local/tests/OleTxTests.cs
@@ -28,9 +28,11 @@ public OleTxTests(OleTxFixture fixture)
     [InlineData(Phase1Vote.ForceRollback, Phase1Vote.Prepared, EnlistmentOutcome.Aborted, EnlistmentOutcome.Aborted, TransactionStatus.Aborted)]
     public void Two_durable_enlistments_commit(Phase1Vote vote1, Phase1Vote vote2, EnlistmentOutcome expectedOutcome1, EnlistmentOutcome expectedOutcome2, TransactionStatus expectedTxStatus)
     {
-        if (!Environment.Is64BitProcess)
+        if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
         {
-            return; // Temporarily skip on 32-bit where we have an issue
+            // Temporarily skip on 32-bit where we have an issue
+            // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+            return;
         }
 
         using var tx = new CommittableTransaction();
@@ -61,9 +63,11 @@ public void Two_durable_enlistments_commit(Phase1Vote vote1, Phase1Vote vote2, E
     [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
     public void Two_durable_enlistments_rollback()
     {
-        if (!Environment.Is64BitProcess)
+        if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
         {
-            return; // Temporarily skip on 32-bit where we have an issue
+            // Temporarily skip on 32-bit where we have an issue
+            // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+            return;
         }
 
         using var tx = new CommittableTransaction();
@@ -89,9 +93,11 @@ public void Two_durable_enlistments_rollback()
     [InlineData(2)]
     public void Volatile_and_durable_enlistments(int volatileCount)
     {
-        if (!Environment.Is64BitProcess)
+        if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
         {
-            return; // Temporarily skip on 32-bit where we have an issue
+            // Temporarily skip on 32-bit where we have an issue
+            // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+            return;
         }
 
         using var tx = new CommittableTransaction();
@@ -122,9 +128,11 @@ public void Volatile_and_durable_enlistments(int volatileCount)
     [ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]
     public void Promotion()
     {
-        if (!Environment.Is64BitProcess)
+        if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
         {
-            return; // Temporarily skip on 32-bit where we have an issue
+            // Temporarily skip on 32-bit where we have an issue
+            // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+            return;
         }
 
         // This simulates the full promotable flow, as implemented for SQL Server.
@@ -301,9 +309,11 @@ public void SinglePhaseCommit(SinglePhaseEnlistment singlePhaseEnlistment)
     [ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]
     public void Recovery()
     {
-        if (!Environment.Is64BitProcess)
+        if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
         {
-            return; // Temporarily skip on 32-bit where we have an issue
+            // Temporarily skip on 32-bit where we have an issue
+            // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+            return;
         }
 
         // We are going to spin up an external process to also enlist in the transaction, and then to crash when it
@@ -413,9 +423,11 @@ public void InDoubt(Enlistment enlistment)
     [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
     public void TransmitterPropagationToken()
     {
-        if (!Environment.Is64BitProcess)
+        if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
         {
-            return; // Temporarily skip on 32-bit where we have an issue
+            // Temporarily skip on 32-bit where we have an issue
+            // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+            return;
         }
 
         using var tx = new CommittableTransaction();
@@ -434,9 +446,11 @@ public void TransmitterPropagationToken()
     [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
     public void GetExportCookie()
     {
-        if (!Environment.Is64BitProcess)
+        if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
         {
-            return; // Temporarily skip on 32-bit where we have an issue
+            // Temporarily skip on 32-bit where we have an issue
+            // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+            return;
         }
 
         using var tx = new CommittableTransaction();
@@ -483,9 +497,11 @@ public class OleTxFixture
     {
         public OleTxFixture()
         {
-            if (!Environment.Is64BitProcess)
+            if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
             {
-                return; // Temporarily skip on 32-bit where we have an issue
+                // Temporarily skip on 32-bit where we have an issue
+                // ARM64 issue: https://github.com/dotnet/runtime/issues/74170
+                return;
             }
 
             // In CI, we sometimes get XACT_E_TMNOTAVAILABLE on the very first attempt to connect to MSDTC;

Original file line number	Diff line number	Diff line change
`@@ -28,9 +28,11 @@ public OleTxTests(OleTxFixture fixture)`
`28`	`28`	`[InlineData(Phase1Vote.ForceRollback, Phase1Vote.Prepared, EnlistmentOutcome.Aborted, EnlistmentOutcome.Aborted, TransactionStatus.Aborted)]`
`29`	`29`	`public void Two_durable_enlistments_commit(Phase1Vote vote1, Phase1Vote vote2, EnlistmentOutcome expectedOutcome1, EnlistmentOutcome expectedOutcome2, TransactionStatus expectedTxStatus)`
`30`	`30`	`{`
`31`		`- if (!Environment.Is64BitProcess)`
	`31`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`32`	`32`	`{`
`33`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`33`	`+ // Temporarily skip on 32-bit where we have an issue`
	`34`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`35`	`+ return;`
`34`	`36`	`}`
`35`	`37`
`36`	`38`	`using var tx = new CommittableTransaction();`
`@@ -61,9 +63,11 @@ public void Two_durable_enlistments_commit(Phase1Vote vote1, Phase1Vote vote2, E`
`61`	`63`	`[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]`
`62`	`64`	`public void Two_durable_enlistments_rollback()`
`63`	`65`	`{`
`64`		`- if (!Environment.Is64BitProcess)`
	`66`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`65`	`67`	`{`
`66`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`68`	`+ // Temporarily skip on 32-bit where we have an issue`
	`69`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`70`	`+ return;`
`67`	`71`	`}`
`68`	`72`
`69`	`73`	`using var tx = new CommittableTransaction();`
`@@ -89,9 +93,11 @@ public void Two_durable_enlistments_rollback()`
`89`	`93`	`[InlineData(2)]`
`90`	`94`	`public void Volatile_and_durable_enlistments(int volatileCount)`
`91`	`95`	`{`
`92`		`- if (!Environment.Is64BitProcess)`
	`96`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`93`	`97`	`{`
`94`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`98`	`+ // Temporarily skip on 32-bit where we have an issue`
	`99`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`100`	`+ return;`
`95`	`101`	`}`
`96`	`102`
`97`	`103`	`using var tx = new CommittableTransaction();`
`@@ -122,9 +128,11 @@ public void Volatile_and_durable_enlistments(int volatileCount)`
`122`	`128`	`[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]`
`123`	`129`	`public void Promotion()`
`124`	`130`	`{`
`125`		`- if (!Environment.Is64BitProcess)`
	`131`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`126`	`132`	`{`
`127`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`133`	`+ // Temporarily skip on 32-bit where we have an issue`
	`134`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`135`	`+ return;`
`128`	`136`	`}`
`129`	`137`
`130`	`138`	`// This simulates the full promotable flow, as implemented for SQL Server.`
`@@ -301,9 +309,11 @@ public void SinglePhaseCommit(SinglePhaseEnlistment singlePhaseEnlistment)`
`301`	`309`	`[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]`
`302`	`310`	`public void Recovery()`
`303`	`311`	`{`
`304`		`- if (!Environment.Is64BitProcess)`
	`312`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`305`	`313`	`{`
`306`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`314`	`+ // Temporarily skip on 32-bit where we have an issue`
	`315`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`316`	`+ return;`
`307`	`317`	`}`
`308`	`318`
`309`	`319`	`// We are going to spin up an external process to also enlist in the transaction, and then to crash when it`
`@@ -413,9 +423,11 @@ public void InDoubt(Enlistment enlistment)`
`413`	`423`	`[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]`
`414`	`424`	`public void TransmitterPropagationToken()`
`415`	`425`	`{`
`416`		`- if (!Environment.Is64BitProcess)`
	`426`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`417`	`427`	`{`
`418`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`428`	`+ // Temporarily skip on 32-bit where we have an issue`
	`429`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`430`	`+ return;`
`419`	`431`	`}`
`420`	`432`
`421`	`433`	`using var tx = new CommittableTransaction();`
`@@ -434,9 +446,11 @@ public void TransmitterPropagationToken()`
`434`	`446`	`[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]`
`435`	`447`	`public void GetExportCookie()`
`436`	`448`	`{`
`437`		`- if (!Environment.Is64BitProcess)`
	`449`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`438`	`450`	`{`
`439`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`451`	`+ // Temporarily skip on 32-bit where we have an issue`
	`452`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`453`	`+ return;`
`440`	`454`	`}`
`441`	`455`
`442`	`456`	`using var tx = new CommittableTransaction();`
`@@ -483,9 +497,11 @@ public class OleTxFixture`
`483`	`497`	`{`
`484`	`498`	`public OleTxFixture()`
`485`	`499`	`{`
`486`		`- if (!Environment.Is64BitProcess)`
	`500`	`+ if (!Environment.Is64BitProcess \|\| PlatformDetection.IsArm64Process)`
`487`	`501`	`{`
`488`		`- return; // Temporarily skip on 32-bit where we have an issue`
	`502`	`+ // Temporarily skip on 32-bit where we have an issue`
	`503`	`+ // ARM64 issue: https://github.com/dotnet/runtime/issues/74170`
	`504`	`+ return;`
`489`	`505`	`}`
`490`	`506`
`491`	`507`	`// In CI, we sometimes get XACT_E_TMNOTAVAILABLE on the very first attempt to connect to MSDTC;`