[release/7.0-staging][wasm][debugger] Improve debugger performance (#88602)

* fix debugger performance

* Update src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs

Co-authored-by: Ankit Jain <radical@gmail.com>

* addressing @radical comments

---------

Co-authored-by: Ankit Jain <radical@gmail.com>

Author: thaystg

src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs

@@ -1475,61 +1475,56 @@ public IEnumerable<SourceFile> Add(SessionId id, string name, byte[] assembly_da
             }
         }
 
-        public async IAsyncEnumerable<SourceFile> Load(SessionId id, string[] loaded_files, ExecutionContext context, bool useDebuggerProtocol, [EnumeratorCancellation] CancellationToken token)
+        public async IAsyncEnumerable<SourceFile> Load(SessionId id, string[] loaded_files, ExecutionContext context, bool tryUseDebuggerProtocol, [EnumeratorCancellation] CancellationToken token)
         {
             var asm_files = new List<string>();
             List<DebugItem> steps = new List<DebugItem>();
 
-            if (!useDebuggerProtocol)
+            var pdb_files = new List<string>();
+            foreach (string file_name in loaded_files)
             {
-                var pdb_files = new List<string>();
-                foreach (string file_name in loaded_files)
-                {
-                    if (file_name.EndsWith(".pdb", StringComparison.OrdinalIgnoreCase))
-                        pdb_files.Add(file_name);
-                    else
-                        asm_files.Add(file_name);
-                }
+                if (file_name.EndsWith(".pdb", StringComparison.OrdinalIgnoreCase))
+                    pdb_files.Add(file_name);
+                else
+                    asm_files.Add(file_name);
+            }
 
-                foreach (string url in asm_files)
+            foreach (string url in asm_files)
+            {
+                try
                 {
-                    try
-                    {
-                        string candidate_pdb = Path.ChangeExtension(url, "pdb");
-                        string pdb = pdb_files.FirstOrDefault(n => n == candidate_pdb);
+                    string candidate_pdb = Path.ChangeExtension(url, "pdb");
+                    string pdb = pdb_files.FirstOrDefault(n => n == candidate_pdb);
 
-                        steps.Add(
-                            new DebugItem
-                            {
-                                Url = url,
-                                Data = Task.WhenAll(MonoProxy.HttpClient.GetByteArrayAsync(url, token), pdb != null ? MonoProxy.HttpClient.GetByteArrayAsync(pdb, token) : Task.FromResult<byte[]>(null))
-                            });
-                    }
-                    catch (Exception e)
-                    {
-                        logger.LogDebug($"Failed to read {url} ({e.Message})");
-                    }
+                    steps.Add(
+                        new DebugItem
+                        {
+                            Url = url,
+                            Data = Task.WhenAll(MonoProxy.HttpClient.GetByteArrayAsync(url, token), pdb != null ? MonoProxy.HttpClient.GetByteArrayAsync(pdb, token) : Task.FromResult<byte[]>(null))
+                        });
                 }
-            }
-            else
-            {
-                foreach (string file_name in loaded_files)
+                catch (Exception e)
                 {
-                    if (file_name.EndsWith(".pdb", StringComparison.OrdinalIgnoreCase))
-                        continue;
-                    try
+                    if (tryUseDebuggerProtocol)
                     {
-                        string unescapedFileName = Uri.UnescapeDataString(file_name);
-                        steps.Add(
+                        try
+                        {
+                            string unescapedFileName = Uri.UnescapeDataString(url);
+                            steps.Add(
                             new DebugItem
                             {
-                                Url = file_name,
+                                Url = url,
                                 Data = context.SdbAgent.GetBytesFromAssemblyAndPdb(Path.GetFileName(unescapedFileName), token)
                             });
+                        }
+                        catch (Exception ex)
+                        {
+                            logger.LogDebug($"Failed to get bytes using debugger protocol {url} ({ex.Message})");
+                        }
                     }
-                    catch (Exception e)
+                    else
                     {
-                        logger.LogDebug($"Failed to read {file_name} ({e.Message})");
+                        logger.LogDebug($"Failed to read {url} ({e.Message})");
                     }
                 }
             }