Cleanup Windows error mode setting with media insertion propmt (#121464)

huoyaoyuan · web-flow · commit 029aadd72a1b · 2025-11-08T11:47:30.000-08:00
According to https://devblogs.microsoft.com/oldnewthing/20170330-00/ , SEM_NOOPENFILEERRORBOX only has effect on Win16 API.
diff --git a/src/coreclr/inc/holder.h b/src/coreclr/inc/holder.h
@@ -1166,7 +1166,7 @@ class ErrorModeHolder final
     ErrorModeHolder()
         : m_revert{ FALSE }
     {
-        DWORD newMode = SEM_NOOPENFILEERRORBOX | SEM_FAILCRITICALERRORS;
+        DWORD newMode = SEM_FAILCRITICALERRORS;
         m_revert = ::SetThreadErrorMode(newMode, &m_oldMode);
     }
     ~ErrorModeHolder() noexcept
diff --git a/src/libraries/System.IO.FileSystem.DriveInfo/src/System/IO/DriveInfo.Windows.cs b/src/libraries/System.IO.FileSystem.DriveInfo/src/System/IO/DriveInfo.Windows.cs
@@ -48,19 +48,13 @@ public long AvailableFreeSpace
             get
             {
                 long userBytes, totalBytes, freeBytes;
-                uint oldMode;
-                bool success = Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);
-                try
+
+                using (DisableMediaInsertionPrompt.Create())
                 {
                     bool r = Interop.Kernel32.GetDiskFreeSpaceEx(Name, out userBytes, out totalBytes, out freeBytes);
                     if (!r)
                         throw Error.GetExceptionForLastWin32DriveError(Name);
                 }
-                finally
-                {
-                    if (success)
-                        Interop.Kernel32.SetThreadErrorMode(oldMode, out _);
-                }
                 return userBytes;
             }
         }
@@ -70,19 +64,13 @@ public long TotalFreeSpace
             get
             {
                 long userBytes, totalBytes, freeBytes;
-                uint oldMode;
-                bool success = Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);
-                try
+
+                using (DisableMediaInsertionPrompt.Create())
                 {
                     bool r = Interop.Kernel32.GetDiskFreeSpaceEx(Name, out userBytes, out totalBytes, out freeBytes);
                     if (!r)
                         throw Error.GetExceptionForLastWin32DriveError(Name);
                 }
-                finally
-                {
-                    if (success)
-                        Interop.Kernel32.SetThreadErrorMode(oldMode, out _);
-                }
                 return freeBytes;
             }
         }
@@ -94,18 +82,13 @@ public long TotalSize
                 // Don't cache this, to handle variable sized floppy drives
                 // or other various removable media drives.
                 long userBytes, totalBytes, freeBytes;
-                uint oldMode;
-                Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);
-                try
+
+                using (DisableMediaInsertionPrompt.Create())
                 {
                     bool r = Interop.Kernel32.GetDiskFreeSpaceEx(Name, out userBytes, out totalBytes, out freeBytes);
                     if (!r)
                         throw Error.GetExceptionForLastWin32DriveError(Name);
                 }
-                finally
-                {
-                    Interop.Kernel32.SetThreadErrorMode(oldMode, out _);
-                }
                 return totalBytes;
             }
         }
@@ -142,9 +125,7 @@ public unsafe string VolumeLabel
             [SupportedOSPlatform("windows")]
             set
             {
-                uint oldMode;
-                bool success = Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);
-                try
+                using (DisableMediaInsertionPrompt.Create())
                 {
                     bool r = Interop.Kernel32.SetVolumeLabel(Name, value);
                     if (!r)
@@ -156,11 +137,6 @@ public unsafe string VolumeLabel
                         throw Error.GetExceptionForWin32DriveError(errorCode, Name);
                     }
                 }
-                finally
-                {
-                    if (success)
-                        Interop.Kernel32.SetThreadErrorMode(oldMode, out _);
-                }
             }
         }
     }
diff --git a/src/mono/mono/metadata/domain.c b/src/mono/mono/metadata/domain.c
@@ -114,7 +114,7 @@ mono_init_internal (const char *root_domain_name)
 
 #if defined(HOST_WIN32) && HAVE_API_SUPPORT_WIN32_SET_ERROR_MODE
 	/* Avoid system error message boxes. */
-	SetErrorMode (SEM_FAILCRITICALERRORS | SEM_NOOPENFILEERRORBOX);
+	SetErrorMode (SEM_FAILCRITICALERRORS);
 #endif
 
 #ifndef HOST_WIN32

Original file line number	Diff line number	Diff line change
`@@ -1166,7 +1166,7 @@ class ErrorModeHolder final`
`1166`	`1166`	`ErrorModeHolder()`
`1167`	`1167`	`: m_revert{ FALSE }`
`1168`	`1168`	`{`
`1169`		`- DWORD newMode = SEM_NOOPENFILEERRORBOX \| SEM_FAILCRITICALERRORS;`
	`1169`	`+ DWORD newMode = SEM_FAILCRITICALERRORS;`
`1170`	`1170`	`m_revert = ::SetThreadErrorMode(newMode, &m_oldMode);`
`1171`	`1171`	`}`
`1172`	`1172`	`~ErrorModeHolder() noexcept`
Original file line number	Diff line number	Diff line change
`@@ -48,19 +48,13 @@ public long AvailableFreeSpace`
`48`	`48`	`get`
`49`	`49`	`{`
`50`	`50`	`long userBytes, totalBytes, freeBytes;`
`51`		`- uint oldMode;`
`52`		`- bool success = Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);`
`53`		`- try`
	`51`	`+`
	`52`	`+ using (DisableMediaInsertionPrompt.Create())`
`54`	`53`	`{`
`55`	`54`	`bool r = Interop.Kernel32.GetDiskFreeSpaceEx(Name, out userBytes, out totalBytes, out freeBytes);`
`56`	`55`	`if (!r)`
`57`	`56`	`throw Error.GetExceptionForLastWin32DriveError(Name);`
`58`	`57`	`}`
`59`		`- finally`
`60`		`- {`
`61`		`- if (success)`
`62`		`- Interop.Kernel32.SetThreadErrorMode(oldMode, out _);`
`63`		`- }`
`64`	`58`	`return userBytes;`
`65`	`59`	`}`
`66`	`60`	`}`
`@@ -70,19 +64,13 @@ public long TotalFreeSpace`
`70`	`64`	`get`
`71`	`65`	`{`
`72`	`66`	`long userBytes, totalBytes, freeBytes;`
`73`		`- uint oldMode;`
`74`		`- bool success = Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);`
`75`		`- try`
	`67`	`+`
	`68`	`+ using (DisableMediaInsertionPrompt.Create())`
`76`	`69`	`{`
`77`	`70`	`bool r = Interop.Kernel32.GetDiskFreeSpaceEx(Name, out userBytes, out totalBytes, out freeBytes);`
`78`	`71`	`if (!r)`
`79`	`72`	`throw Error.GetExceptionForLastWin32DriveError(Name);`
`80`	`73`	`}`
`81`		`- finally`
`82`		`- {`
`83`		`- if (success)`
`84`		`- Interop.Kernel32.SetThreadErrorMode(oldMode, out _);`
`85`		`- }`
`86`	`74`	`return freeBytes;`
`87`	`75`	`}`
`88`	`76`	`}`
`@@ -94,18 +82,13 @@ public long TotalSize`
`94`	`82`	`// Don't cache this, to handle variable sized floppy drives`
`95`	`83`	`// or other various removable media drives.`
`96`	`84`	`long userBytes, totalBytes, freeBytes;`
`97`		`- uint oldMode;`
`98`		`- Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);`
`99`		`- try`
	`85`	`+`
	`86`	`+ using (DisableMediaInsertionPrompt.Create())`
`100`	`87`	`{`
`101`	`88`	`bool r = Interop.Kernel32.GetDiskFreeSpaceEx(Name, out userBytes, out totalBytes, out freeBytes);`
`102`	`89`	`if (!r)`
`103`	`90`	`throw Error.GetExceptionForLastWin32DriveError(Name);`
`104`	`91`	`}`
`105`		`- finally`
`106`		`- {`
`107`		`- Interop.Kernel32.SetThreadErrorMode(oldMode, out _);`
`108`		`- }`
`109`	`92`	`return totalBytes;`
`110`	`93`	`}`
`111`	`94`	`}`
`@@ -142,9 +125,7 @@ public unsafe string VolumeLabel`
`142`	`125`	`[SupportedOSPlatform("windows")]`
`143`	`126`	`set`
`144`	`127`	`{`
`145`		`- uint oldMode;`
`146`		`- bool success = Interop.Kernel32.SetThreadErrorMode(Interop.Kernel32.SEM_FAILCRITICALERRORS, out oldMode);`
`147`		`- try`
	`128`	`+ using (DisableMediaInsertionPrompt.Create())`
`148`	`129`	`{`
`149`	`130`	`bool r = Interop.Kernel32.SetVolumeLabel(Name, value);`
`150`	`131`	`if (!r)`
`@@ -156,11 +137,6 @@ public unsafe string VolumeLabel`
`156`	`137`	`throw Error.GetExceptionForWin32DriveError(errorCode, Name);`
`157`	`138`	`}`
`158`	`139`	`}`
`159`		`- finally`
`160`		`- {`
`161`		`- if (success)`
`162`		`- Interop.Kernel32.SetThreadErrorMode(oldMode, out _);`
`163`		`- }`
`164`	`140`	`}`
`165`	`141`	`}`
`166`	`142`	`}`