Make RuntimeHostInfoTests more robust #81080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dotnet/roslyn-compiler for reviews; this fixes a test class that is failing in main CI (in a leg which doesn't run in PRs though) |
| catch (Exception ex) | ||
| { | ||
| Environment.SetEnvironmentVariable("PATH", previousPath); | ||
| // If resolution fails, use the original path |
Member
There was a problem hiding this comment.
if things fail... should we just fail entirely? unclear why we're falling back in that case.
Member
Author
There was a problem hiding this comment.
You're right, I think we could just fail considering this is a test; thanks.
CyrusNajmabadi
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing "single machine" leg in main (which doesn't run on PRs). This broke with #80859.
The fix is to control the DOTNET_HOST_PATH env var in the tests because it can affect their behavior if set from the outside.
And normalizing paths so they can be compared (there is a
substalias used in the single machine legs).Reusing a helper for setting env vars which Copilot found for me in another test class.