Remove CS1998 warning entirely and remove dependent C# code fix providers #80144

Copilot · 2025-09-04T17:26:54Z

This PR removes the CS1998 (WRN_AsyncLacksAwaits) warning entirely from the C# compiler and removes all dependent C# infrastructure, based on the team decision that this warning is no longer beneficial.

Relates to test plan #75960.
Closes #77001.

Changes Made

Core compiler changes:

Removed CS1998 diagnostic emission from DefiniteAssignment.cs
Commented out WRN_AsyncLacksAwaits enum definition in ErrorCode.cs
Commented out references in ErrorFacts.cs and generated files
Deleted resource strings from CSharpResources.resx and all XLF translation files

Infrastructure cleanup:

Completely removed C# code fix providers (CSharpRemoveAsyncModifierCodeFixProvider and CSharpMakeMethodSynchronousCodeFixProvider) and their tests
Preserved abstract base classes and Visual Basic implementations for future VB consolidation
Updated telemetry descriptions to remove C# code fix provider references

Test updates:

Updated 32+ test files across the compiler test suite to remove CS1998 expectations
Removed C#-specific test classes for the deleted code fix providers

The warning infrastructure is now fully disabled for C# and won't be used again. Abstract base classes remain available for Visual Basic, which may continue to benefit from these diagnostics.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot · 2025-09-04T17:26:55Z

@333fred 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

333fred · 2025-09-04T17:53:52Z

@copilot please comment out the warning so we don't use it again in the future, and delete the resources associated with it.

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot · 2025-09-04T18:04:31Z

@copilot please comment out the warning so we don't use it again in the future, and delete the resources associated with it.

Done! I've commented out the CS1998 warning definition and deleted the associated resources:

Changes made (ca2c367):

Commented out WRN_AsyncLacksAwaits = 1998 in ErrorCode.cs to prevent future usage
Commented out references in ErrorFacts.cs and Generated files
Removed resource strings from CSharpResources.resx
Disabled both CSharpRemoveAsyncModifierCodeFixProvider and CSharpMakeMethodSynchronousCodeFixProvider (they can't function without the warning)
Updated scripting tests and disabled test classes that relied on CS1998

The warning infrastructure is now fully disabled and won't be used again in the future.

333fred · 2025-09-04T18:17:38Z

@copilot there are errors:

D:\a\_work\1\s\.packages\microsoft.dotnet.xlifftasks\10.0.0-beta.25427.2\build\Microsoft.DotNet.XliffTasks.targets(85,5): error : 'xlf\CSharpResources.cs.xlf' is out-of-date with 'CSharpResources.resx'. Run `msbuild /t:UpdateXlf` to update .xlf files or set UpdateXlfOnBuild=true to update them on every build, but note that it is strongly discouraged to set UpdateXlfOnBuild=true in official/CI build environments as they should not modify source code during the build. [D:\a\_work\1\s\src\Compilers\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.csproj::TargetFramework=net9.0]
D:\a\_work\1\s\.packages\microsoft.dotnet.xlifftasks\10.0.0-beta.25427.2\build\Microsoft.DotNet.XliffTasks.targets(85,5): error : 'xlf\CSharpResources.cs.xlf' is out-of-date with 'CSharpResources.resx'. Run `msbuild /t:UpdateXlf` to update .xlf files or set UpdateXlfOnBuild=true to update them on every build, but note that it is strongly discouraged to set UpdateXlfOnBuild=true in official/CI build environments as they should not modify source code during the build. [D:\a\_work\1\s\src\Compilers\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.csproj::TargetFramework=netstandard2.0]

333fred · 2025-09-04T18:24:20Z

@CyrusNajmabadi what do you want to do about CSharpRemoveAsyncModifierCodeFixProvider and CSharpMakeMethodSynchronousCodeFixProvider?

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot · 2025-09-04T18:25:00Z

@copilot there are errors:

D:\a\_work\1\s\.packages\microsoft.dotnet.xlifftasks\10.0.0-beta.25427.2\build\Microsoft.DotNet.XliffTasks.targets(85,5): error : 'xlf\CSharpResources.cs.xlf' is out-o...

Fixed! I've updated all XLF translation files to remove the WRN_AsyncLacksAwaits and WRN_AsyncLacksAwaits_Title entries that were causing the out-of-sync errors. The build errors should now be resolved (a2dde98).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

4zjvsblobprodcus390.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)
6s7vsblobprodcus313.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)
80zvsblobprodcus35.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)
ckzvsblobprodcus347.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)
l49vsblobprodcus358.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)
m16vsblobprodcus374.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)
pe3vsblobprodcus354.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)
ytvvsblobprodcus310.vsblob.vsassets.io
- Triggering command: dotnet build src/Compilers/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.csproj --no-restore (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

333fred · 2025-09-04T18:25:26Z

@copilot remove those unrelated changes in global.json and build.cmd

CyrusNajmabadi · 2025-09-04T18:26:47Z

@333fred are we removing the diagnostic entirely?

If so, we can just remove these fixers.

I assume we're doing the same for VB for consistency? Or are we intending divergence here?

333fred · 2025-09-04T18:27:33Z

@333fred are we removing the diagnostic entirely?

Yes.

I assume we're doing the same for VB for consistency? Or are we intending divergence here?

We'll need to clarify with folks. VB is not getting runtime async, so the benefits would be more murky.

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot · 2025-09-04T18:28:25Z

@copilot remove those unrelated changes in global.json and build.cmd

Removed the unrelated changes to global.json (newline) and Build.cmd (file permissions) in commit 800934c. The files are now restored to their original state.

333fred · 2025-09-11T16:59:31Z

@dotnet/roslyn-compiler for reviews please.

src/Compilers/CSharp/Test/Semantic/Semantics/LocalFunctionTests.cs

* upstream/main: (201 commits) Handle extension blocks in CLS compliance checker (#80251) Fix Simplify Simplify Simplify Simplify Simplify Add doc for GetInferredNullableAnnotation (#80245) Rename files to match type within Implement ref local hoisting in runtime async. Closes #79763. Pull ref initialization hoisting into a reusable class for use in runtime async REvert Break cycle for lambda using field keyword with inferred return type (#79995) Simplify tests Simplify Fixup New extension Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API (#80170) In process Support 'add using' for modern extension methods ...

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAsyncSpillTests.cs

src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs

jcouv

Done with review pass (commit 15)

jcouv

LGTM Thanks (commit 15)

* upstream/main: (206 commits) Remove bogus xlf tag (#80357) Fix missing type argument checks Add tests Use dotnet run file for generating compiler code (#80248) Only restore based on assets file changes if the actual content changed (#80341) make expressionbody analyzer use semanticspananalysis (#80339) [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (#80342) Properly populate ExportedType metadata table in presence of extension block. (#80311) Propagate `params` to lambdas and local functions (#79880) Change 17.15 to VS 2026 preview. (#80325) Improve virtualproject support for older .NET SDKs (#80324) Update dependencies from https://github.com/dotnet/dotnet build 283666 (#80344) Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (#80343) Simplifying Fix tests Fix tests Fix introduce variable placement in top level statements move to immutable types in signature help move to immutable types in signature help Fix check ...

333fred · 2025-09-18T20:20:30Z

@jjonescz any other comments?

Initial plan

ba04869

Copilot AI assigned Copilot and 333fred Sep 4, 2025

Copilot started work on behalf of 333fred September 4, 2025 17:27 View session

Copilot AI and others added 3 commits September 4, 2025 17:35

Remove CS1998 warning emission and start updating tests

9216cd3

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Update key async binding tests - remove CS1998 expectations

217edc4

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Complete removal of CS1998 warning from all test files

4139e06

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Consider not emitting CS1998 for interface implementations / method overrides~~ Remove CS1998 warning entirely for async methods without await operators Sep 4, 2025

Copilot AI requested a review from 333fred September 4, 2025 17:49

Copilot finished work on behalf of 333fred September 4, 2025 17:49

Copilot started work on behalf of 333fred September 4, 2025 17:54 View session

Comment out CS1998 warning definition and delete associated resources

ca2c367

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

dotnet-policy-service bot added the VSCode label Sep 4, 2025

Copilot AI changed the title ~~Remove CS1998 warning entirely for async methods without await operators~~ Remove CS1998 warning entirely and disable dependent infrastructure Sep 4, 2025

Copilot finished work on behalf of 333fred September 4, 2025 18:05

Copilot started work on behalf of 333fred September 4, 2025 18:17 View session

Update XLF files to remove WRN_AsyncLacksAwaits translations

a2dde98

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot finished work on behalf of 333fred September 4, 2025 18:25

Copilot started work on behalf of 333fred September 4, 2025 18:25 View session

Revert unrelated changes to global.json and Build.cmd

800934c

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

333fred added the Area-Compilers label Sep 11, 2025

jjonescz approved these changes Sep 12, 2025

View reviewed changes

src/Compilers/CSharp/Test/Semantic/Semantics/LocalFunctionTests.cs Show resolved Hide resolved

333fred added 4 commits September 12, 2025 09:49

Restore description for telemetry

59362e5

Update CodeGenAsyncSpillTests after merge

305217c

Update baselines

31f0027

jjonescz reviewed Sep 13, 2025

View reviewed changes

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAsyncSpillTests.cs Show resolved Hide resolved

jcouv self-assigned this Sep 16, 2025

jcouv mentioned this pull request Sep 16, 2025

Test Plan for Runtime Async #75960

Open

37 tasks

jcouv reviewed Sep 16, 2025

View reviewed changes

src/Compilers/CSharp/Portable/Errors/ErrorCode.cs Outdated Show resolved Hide resolved

jcouv reviewed Sep 17, 2025

View reviewed changes

src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs Show resolved Hide resolved

jcouv reviewed Sep 17, 2025

View reviewed changes

jcouv approved these changes Sep 18, 2025

View reviewed changes

333fred added 2 commits September 18, 2025 10:53

Remove more superfluous warnings.

19efba6

jjonescz approved these changes Sep 19, 2025

View reviewed changes

More line numbers

9041e61

333fred enabled auto-merge (squash) September 19, 2025 16:12

333fred merged commit 84133cc into main Sep 19, 2025
27 of 28 checks passed

dotnet-policy-service bot added this to the Next milestone Sep 19, 2025

333fred deleted the copilot/fix-77001 branch September 19, 2025 18:08

dotnet-bot mentioned this pull request Sep 22, 2025

[Automated] PRs inserted in VS build main-11021.14 #80397

Closed

akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025

This was referenced Sep 25, 2025

[Automated] PRs inserted in VS build feature.debugger.main-11023.335 #80458

Closed

[Automated] PRs inserted in VS build feature.Wix5-11030.241 #80529

Closed

Remove CS1998 warning entirely and remove dependent C# code fix providers #80144

Remove CS1998 warning entirely and remove dependent C# code fix providers #80144

Uh oh!

Conversation

Copilot AI commented Sep 4, 2025 • edited by 333fred Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Uh oh!

Copilot AI commented Sep 4, 2025

Uh oh!

333fred commented Sep 4, 2025

Uh oh!

Copilot AI commented Sep 4, 2025

Uh oh!

333fred commented Sep 4, 2025

Uh oh!

333fred commented Sep 4, 2025

Uh oh!

Copilot AI commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

333fred commented Sep 4, 2025

Uh oh!

CyrusNajmabadi commented Sep 4, 2025

Uh oh!

333fred commented Sep 4, 2025

Uh oh!

Copilot AI commented Sep 4, 2025

Uh oh!

333fred commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcouv left a comment

Choose a reason for hiding this comment

Uh oh!

jcouv left a comment

Choose a reason for hiding this comment

Uh oh!

333fred commented Sep 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Copilot AI commented Sep 4, 2025 •

edited by 333fred

Loading

Copilot AI commented Sep 4, 2025 •

edited

Loading