Support declaration of instance increment operators #76991
Conversation
ghost
added
the
untriaged
|
|
||
| this.CheckUnsafeModifier(declarationModifiers, diagnostics); | ||
|
|
||
| bool isIncrementDecrement = syntax is OperatorDeclarationSyntax { OperatorToken.RawKind: (int)SyntaxKind.PlusPlusToken or (int)SyntaxKind.MinusMinusToken }; |
There was a problem hiding this comment.
Nit: this pattern is done 3 times in this file, consider extracting a helper. #Resolved
| <value>User-defined operator '{0}' must be declared public</value> | ||
| </data> | ||
| <data name="ERR_BadIncrementOpArgs" xml:space="preserve"> | ||
| <value>Overloaded instance increment operator '{0}' takes no parameters</value> |
There was a problem hiding this comment.
Consider using the imperative form here: must take no parameters, for example. Right now, it's unclear from the wording how many parameters are supposed to be present. #Resolved
| { | ||
| Binder.CheckFeatureAvailability(syntax, MessageID.IDS_FeatureUserDefinedCompoundAssignmentOperators, diagnostics, ((OperatorDeclarationSyntax)syntax).OperatorToken.GetLocation()); | ||
|
|
||
| if (parameterCount is not (0 or 2)) |
There was a problem hiding this comment.
What's the reason for allowing 2 here? I would think that we should prefer giving errors about the specific operator the user typed out, rather than presuming the user meant to type a binary operator instead. #Resolved
There was a problem hiding this comment.
What's the reason for allowing 2 here? I would think that we should prefer giving errors about the specific operator the user typed out, rather than presuming the user meant to type a binary operator instead.
Parser reports an error for the 2 parameters case. I don't want to move all that parameter checking out of the parser, so I just made the smallest change to let "might be a success" cases through in the parser.
src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs
Show resolved
Hide resolved
|
@cston, @dotnet/roslyn-compiler For the second review |
AlekseyTs
merged commit 3d90c17
into
dotnet:features/UserDefinedCompoundAssignment
3 participants
No description provided.