Skip to content

Fix FAR on an alias to a predefined type #76101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix FAR on an alias to a predefined type #76101

merged 3 commits into from
Nov 26, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #74384

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 26, 2024 16:19
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 26, 2024
@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal.

ToddGrun
ToddGrun approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 73f8f97 into dotnet:main Nov 26, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the farAliasToPredefinedType branch November 26, 2024 18:05
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 26, 2024
@dotnet-bot dotnet-bot mentioned this pull request Nov 29, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

Reference highlight doesn't highlight references/usages of type aliases
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet