Skip to content

Bump versions of dependencies coming from maintenance-packages #76076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Nov 25, 2024

@carlossanlop carlossanlop self-assigned this Nov 25, 2024
@carlossanlop carlossanlop requested a review from a team as a code owner November 25, 2024 19:06
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 25, 2024
@carlossanlop carlossanlop force-pushed the BumpMaintenancePackagesDependencies branch from 0127f2b to b522166 Compare November 25, 2024 19:19
@carlossanlop
Copy link
Contributor Author

There's a failure and it looks related:

src\Tools\SemanticSearch\ReferenceAssemblies\SemanticSearch.ReferenceAssemblies.csproj(56,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) GenerateFilteredReferenceAssembliesTask failed with exception:
System.MissingMethodException: Method not found: 'System.ReadOnlySpan`1<!0> System.Collections.Immutable.ImmutableArray`1.AsSpan()'.
   at Microsoft.CodeAnalysis.CryptoBlobParser.IsValidPublicKey(ImmutableArray`1 blob)
   ...

@carlossanlop
Copy link
Contributor Author

Maybe the failure would be resolved by dotnet/msbuild#11038 @ericstj , but @ViktorHofer mentioned it will take a couple months to flow into here. In the meanwhile, I don't know how we should get this failure resolved.

@ericstj
Copy link
Member

ericstj commented Nov 26, 2024

I think you also need the properties and to use those properties where you use the packages. cc @MichaelSimons

Edit: nevermind, I see you have this in the patch in SDK. https://github.com/dotnet/sdk/pull/45042/files#diff-1ea18ff65faa2ae6fed570b83747086d0317f5e4bc325064f6c14319a9c4ff67 I misunderstood where the work was happening first.

@carlossanlop carlossanlop force-pushed the BumpMaintenancePackagesDependencies branch from 3779cb2 to 49d5aea Compare November 27, 2024 00:11
@ViktorHofer ViktorHofer merged commit 47c27db into dotnet:main Nov 27, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 27, 2024
@carlossanlop carlossanlop deleted the BumpMaintenancePackagesDependencies branch December 3, 2024 19:31
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Blocked untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants