[EnC] Implement support for restarting subset of projects affected by rude edits #75874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Interactive
untriaged
tmat
changed the title
Member
Author
|
@davidwengier ptal |
davidwengier
approved these changes
Nov 13, 2024
| public async ValueTask<ManagedHotReloadUpdates> GetUpdatesAsync(CancellationToken cancellationToken) | ||
| [Obsolete] | ||
| public ValueTask<ManagedHotReloadUpdates> GetUpdatesAsync(CancellationToken cancellationToken) | ||
| => GetUpdatesAsync(runningProjects: [], cancellationToken); |
Member
There was a problem hiding this comment.
Does this mean things are broken until the debugger respond? Would it be better to pass all something like currentCompileTimeSolution.Projects.Select(p=>p.FilePath) as the first parameter?
Member
Author
There was a problem hiding this comment.
No, shouldn't be broken. The debugger doesn't currently consume the results that are affected by this input.
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
IManagedHotReloadLanguageService2interface that allows the debugger to restart a subset of processes when a rude edit is encountered instead of terminating the entire debugging session.This includes a new overload of
GetUpdatesAsyncthat takes a list of running projects and returns sets of projects to restart and to rebuild based on dependency analysis of updated projects. This functionality has already been exposed to dotnet-watch, now it will be available to VS debugger as well.Adds a new API
UpdateBaselinesthat discards the initial baselines of specified projects and commits the current solution snapshot. This is to be called when projects affected by rude edits are rebuilt. The next update will start with a new baseline read from newly built metadata.