Standardize on NET pre-proc symbol #74859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A good chunk of our code uses `#if NETCOREAPP` instead of `#if NET` for historical reasons. Did a quick replace so we can standardize on the more idiomatic approach
ghost
added
Area-Compilers
untriaged
Member
Author
|
@dotnet/roslyn-compiler PTAL |
CyrusNajmabadi
approved these changes
Aug 22, 2024
Member
|
Not sure how i feel about code becoming more consistent... |
ToddGrun
reviewed
Aug 22, 2024
|
|
||
| Shared Sub VerifyArgumentExceptionDiagnostic(diagnostic As Diagnostic, generatorName As String, message As String, parameterName As String, Optional initialization As Boolean = False) | ||
| #If NETCOREAPP Then | ||
| #if NET Then |
Contributor
cston
approved these changes
Aug 22, 2024
Member
Author
chsienki
approved these changes
Aug 22, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good chunk of our code uses
#if NETCOREAPPinstead of#if NETfor historical reasons. Did a quick replace so we can standardize on the more idiomatic approach