Remove IChecksummedObject type. #74829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 20, 2024
| protected override Checksum CreateChecksum(AnalyzerReference reference, CancellationToken cancellationToken) | ||
| => reference is TestGeneratorReference generatorReference | ||
| ? generatorReference.Checksum | ||
| : base.CreateChecksum(reference, cancellationToken); |
Member
Author
There was a problem hiding this comment.
this is new, and replaced the existing hijacking point that was using IChecksummedObject.
Member
Author
CyrusNajmabadi
commented
Aug 20, 2024
| /// passed, for ease in unit tests. | ||
| /// </summary> | ||
| public class TestGeneratorReference : AnalyzerReference, IChecksummedObject | ||
| public class TestGeneratorReference : AnalyzerReference |
Member
Author
There was a problem hiding this comment.
the only impl of this interface.
CyrusNajmabadi
commented
Aug 20, 2024
| if (value is IChecksummedObject checksummedObject) | ||
| { | ||
| return checksummedObject.Checksum; | ||
| } |
Member
Author
There was a problem hiding this comment.
existed only to hijack. but we can already do that throuhg normal virtual methods.
CyrusNajmabadi
commented
Aug 20, 2024
| { | ||
| void Serialize(object value, ObjectWriter writer, CancellationToken cancellationToken); | ||
|
|
||
| void SerializeParseOptions(ParseOptions options, ObjectWriter writer); |
Member
Author
There was a problem hiding this comment.
didn't need to be on the itnerface. was never called externally.
dibarbet
approved these changes
Aug 20, 2024
3 tasks
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type existed only for testing purposes. But there's ahn existing pattern we already have to allow customized test behavior here. Having two mechanisms for this was super confusing and led me down a painful debugging hole in one of my branches.