Skip to content

Conversation

@CyrusNajmabadi
Copy link
Member

Cleaning this up before some upcoming refactoring (to ensure we no longer load AnlayzerReferences within VS).

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 19, 2024 17:15
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 19, 2024
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.ComponentModel;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view with whitespace off.


if (project == null)
{
// Construction of BulkObservableCollection requires the main thread
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Construction of BulkObservableCollection requires the main thread

Is this not something needing checked anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just don't care :)

return new SourceGeneratedFileItemSource(item, _workspace, _asyncListener, _threadingContext);
}
[Export(typeof(IAttachedCollectionSourceProvider))]
[Name(nameof(SourceGeneratedFileItemSourceProvider)), Order]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order

Definitely a nit, but I'm curious why this is preferred. I assume it's because there is a relation between this attributes, but it seems easier to miss the OrderAttribute in this form.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. that's basically it. (imo, they should have been merge din the first place :)).

Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants