Move to basic ref assemblies for net40 #74796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
This moves us to use Basic.Reference.Assemblies for our `net40` test assets. This saves ~200MB of I/O on CI restore. This is a purely mechanical change. The bulk of the changes is - Rename `Net40.mscorlib` to `Net40.Resources.mscorlib` - Add an `Import` or `using` for `Basic.Reference.Assemblies` Functionally there should be no change here.
Member
Author
|
@dotnet/roslyn-compiler PTAL |
jaredpar
commented
Aug 18, 2024
| $buildTool = InitializeBuildTool | ||
| $frameworkArg = if ($framework -ne "") { " -p:TargetFramework=$framework" } else { "" } | ||
| $buildArgs = "$($buildTool.Command) -v:m -m -p:RunAnalyzersDuringBuild=false -p:GenerateFullPaths=true$frameworkArg $($projectFileInfo.FullName)" | ||
| $buildArgs = "$($buildTool.Command) -v:m -tl:off -m -p:RunAnalyzersDuringBuild=false -p:GenerateFullPaths=true$frameworkArg $($projectFileInfo.FullName)" |
Member
Author
There was a problem hiding this comment.
The terminal logger isn't compatible with the VS Code problem matcher.
Member
There was a problem hiding this comment.
If we preferred the terminal logger, we could write a matcher for it. https://code.visualstudio.com/Docs/editor/tasks#_defining-a-problem-matcher
Open
3 tasks
jjonescz
approved these changes
Aug 19, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us to use
Basic.Reference.Assembliesfor ournet40testassets. This saves ~200MB of I/O on CI restore.
This is a purely mechanical change. The bulk of the changes is
Net40.mscorlibtoNet40.Resources.mscorlibImportorusingforBasic.Reference.AssembliesFunctionally there should be no change here.
Note there is one test change in
RefStructInterfacesTests(see second commit). AddingBasic.Reference.Assembiles.Net40also updated to the newer version ofBasic.Reference.Assemblies.Net90. That effectively moved us from Preview3 to Preview6 and that has the updated version ofActivator.CreateInstance. Needed to update a baseline to account for that.