Async rename commit #74794
Async rename commit #74794
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -817,6 +849,7 @@ await DismissUIAndRollbackEditsAndEndRenameSessionAsync( | |||
|
|
|||
| private async Task CommitCoreAsync(IUIThreadOperationContext operationContext, bool previewChanges) | |||
| { | |||
| CommitStateChange?.Invoke(this, true); | |||
There was a problem hiding this comment.
In legacy UI, when commit starts, we want to disable these buttons, because you can't edit these options once commit starts.
In new UI, when commit starts this event will make the UI collapse. Because it hides the background indicator tooltip
Serious question: why do we have hte legacy UI. We've had the new UI for at least a year now. I would ask that we have a PR before thsi one that just rips it out and simplifies things greatly. |
@ryzngard knows more here, but for me it's a fallback safe plan when things broken in new UI. |
Make commit operation async in renaming session if the commit behavior is triggered by
enteror in the rename UI.Rename behavior could be reversed back to sync mode by setting
InlineRenameSessionOptionsStorage.RenameAsynchronouslytofalse.How it looks:
In legacy UI, if the renaming operation takes long time:
In new UI, if the renaming operation takes long time: