Modify ISyntaxTreeFactoryService.CreateSyntaxTree to take in an optional SourceText. #74707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal SourceText. I've noticed debugging locally that for every keystroke I'm seeing two StringTexts created that span the entire buffer. The creation of these texts originates from ParsedSyntaxTree needing to create SourceText, and the only way it knowing to do so is by serializing the tree into a string and creating a StringText from it. I *feel* like DocumentState.TryReuseSiblingRoot should be able to utilize the sibling's sourcetext in addition to it's tree, but I'm not 100% positive.
ghost
added
Area-IDE
untriaged
ToddGrun
changed the title
|
Passed ci, my limited testing, and a test insertion, so elevating out of draft status. @CyrusNajmabadi -- how will this break things? |
src/Workspaces/Core/Portable/Workspace/Solution/DocumentState_LinkedFileReuse.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Aug 12, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed debugging locally that for every keystroke I'm seeing two StringTexts created that span the entire buffer. The creation of these texts originates from ParsedSyntaxTree needing to create SourceText, and the only way it knowing to do so is by serializing the tree into a string and creating a StringText from it.
I feel like DocumentState.TryReuseSiblingRoot should be able to utilize the sibling's sourcetext in addition to it's tree, but I'm not 100% positive.