Skip to content

Ensure that GetContentHash produces the same value on different endian machines #74696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 10 commits into from
Aug 9, 2024
Merged

Ensure that GetContentHash produces the same value on different endian machines #74696

CyrusNajmabadi merged 10 commits into from
Aug 9, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Aug 9, 2024 •
edited
Loading

Fixes #74682

  1. We don't have a good way to test htis, absent a dedicated test run on a big endian machine (which is what the runtime team does).
  2. We can definitely take out that copy of the vectorized code, and say if you're before .net 8 that you get the slow impl.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 9, 2024 15:36
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 9, 2024
CyrusNajmabadi
CyrusNajmabadi commented Aug 9, 2024
View reviewed changes
CyrusNajmabadi
CyrusNajmabadi commented Aug 9, 2024
View reviewed changes
stephentoub
stephentoub reviewed Aug 9, 2024
View reviewed changes
stephentoub
stephentoub reviewed Aug 9, 2024
View reviewed changes
stephentoub
stephentoub reviewed Aug 9, 2024
View reviewed changes
stephentoub
stephentoub reviewed Aug 9, 2024
View reviewed changes
stephentoub
stephentoub reviewed Aug 9, 2024
View reviewed changes
CyrusNajmabadi and others added 3 commits August 9, 2024 09:28
@CyrusNajmabadi @stephentoub
Update src/Compilers/Core/Portable/Text/SourceText.cs
9c381ef 
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@CyrusNajmabadi @stephentoub
Update src/Compilers/Core/Portable/Text/SourceText.cs
3289f09 
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@CyrusNajmabadi @stephentoub
Update src/Compilers/Core/Portable/Text/SourceText.cs
c01de49 
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@CyrusNajmabadi CyrusNajmabadi merged commit 2158b59 into dotnet:main Aug 9, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the reverseEndianness branch August 9, 2024 17:46
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 9, 2024
This was referenced Aug 14, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@333fred 333fred 333fred approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

@chsienki chsienki Awaiting requested review from chsienki

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.12 P2

Development

Successfully merging this pull request may close these issues.

The [InterceptsLocation] attribute generates a different "data" string for big-endian platforms

6 participants

@CyrusNajmabadi @333fred @stephentoub @RikkiGibson @cston @dibarbet