Ide options #74053
Merged
Ide options #74053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
tmat
force-pushed
the
IdeOptions
branch
4 times, most recently
from
1254d3c to
1269c73
Compare
3 tasks
...s/Core/Portable/EmbeddedLanguages/RegularExpressions/LanguageServices/RegexOptionsStorage.cs
Show resolved
Hide resolved
Comment on lines
108
to
+109
| [Fact] | ||
| [WorkItem("https://github.com/dotnet/roslyn/issues/62937")] |
There was a problem hiding this comment.
Suggested change
| [Fact] | |
| [WorkItem("https://github.com/dotnet/roslyn/issues/62937")] | |
| [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/62937")] |
CyrusNajmabadi
approved these changes
Jun 28, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves EditorConfigOptionsEnumerator to Features so that it can enumerate editorconfig options defined in Features layer (options used by analyzers implemented only in Features).
Converts options passed to analyzers/code fixes via
IdeAnalyzerOptionsto editorconfig options.Unsupported:
dotnet_unsupported_report_invalid_placeholders_in_string_dot_format_callsdotnet_unsupported_detect_and_offer_editor_features_for_probable_json_stringsdotnet_unsupported_report_invalid_json_patternsdotnet_unsupported_report_invalid_regex_patternsSupported:
dotnet_prefer_system_hash_codeFollow up on #74038.