Skip to content

Fix function pointer expected output on coreclr #68212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2023
Merged

Fix function pointer expected output on coreclr #68212

merged 1 commit into from
May 16, 2023

Conversation

@333fred
Copy link
Member

@333fred 333fred commented May 16, 2023 •
edited
Loading

Fixes #68208

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 16, 2023
@333fred 333fred marked this pull request as ready for review May 16, 2023 20:12
@333fred 333fred requested a review from a team as a code owner May 16, 2023 20:12
@333fred 333fred added Test Test failures in roslyn-CI Feature - Function Pointers Adding Function Pointers and removed untriaged Issues and PRs which have not yet been triaged by a lead labels May 16, 2023
@333fred 333fred enabled auto-merge (squash) May 16, 2023 20:13
@333fred
Copy link
Member Author

333fred commented May 16, 2023

@dotnet/roslyn-compiler for a quick review

@333fred 333fred merged commit 57aebed into dotnet:main May 16, 2023
@ghost ghost added this to the Next milestone May 16, 2023
@333fred 333fred deleted the fix-fnptr-tests branch May 17, 2023 00:17
@allisonchou allisonchou mentioned this pull request May 18, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
@jjonescz jjonescz mentioned this pull request Aug 15, 2023
Merged
JoeRobich added a commit that referenced this pull request Jun 7, 2024
@JoeRobich
Backport test fixes from #68212
1c9c747
@JoeRobich JoeRobich mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers Feature - Function Pointers Adding Function Pointers Test Test failures in roslyn-CI

Projects

None yet

Milestone

17.7 P2

Development

Successfully merging this pull request may close these issues.

Function pointer tests breaking on .NET 8

3 participants

@333fred @cston @Cosifne