Skip to content

Revert #64616 and #64576 #64873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoeRobich merged 2 commits into from
Oct 20, 2022
Merged

Revert #64616 and #64576 #64873

JoeRobich merged 2 commits into from
Oct 20, 2022

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Oct 20, 2022

We're getting exceptions about data not being pinned properly. These PRs made a very subtle change deep where pinning happens, so it's likely they regressed this.

@CyrusNajmabadi
Revert "Merge pull request dotnet#64616 from CyrusNajmabadi/designerA…
13a67a8 
…ttributeStream"

This reverts commit 8ed28cd, reversing
changes made to 795612c.
@CyrusNajmabadi
Revert "Merge pull request dotnet#64576 from CyrusNajmabadi/asyncStre…
ccef2a9 
…amOOP"

This reverts commit 83550ee, reversing
changes made to 5bf1a43.
@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners October 20, 2022 20:31
@ghost ghost added the Area-IDE label Oct 20, 2022
@CyrusNajmabadi CyrusNajmabadi requested a review from genlu October 20, 2022 20:32
@genlu genlu mentioned this pull request Oct 20, 2022
Closed
@JoeRobich JoeRobich disabled auto-merge October 20, 2022 22:22
@JoeRobich JoeRobich merged commit a7f8059 into dotnet:main Oct 20, 2022
@ghost ghost added this to the Next milestone Oct 20, 2022
@allisonchou allisonchou mentioned this pull request Oct 22, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the revertPull branch December 7, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@genlu genlu genlu approved these changes

@dibarbet dibarbet Awaiting requested review from dibarbet

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.5 P1

Development

Successfully merging this pull request may close these issues.

4 participants

@CyrusNajmabadi @JoeRobich @genlu @RikkiGibson