Save CustomAttributesBag before post decoding well known attributes. #64649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids infinite cycle in binding attributes for two or more different symbols. Fixes dotnet#64392.
Contributor
Author
|
@dotnet/roslyn-compiler Please review. |
Contributor
Author
|
@dotnet/roslyn-compiler Please review |
jaredpar
approved these changes
Oct 12, 2022
Contributor
Author
|
@dotnet/roslyn-compiler For the second review. |
333fred
reviewed
Oct 12, 2022
| { | ||
| if (attributeMatchesOpt is null) | ||
| { | ||
| this.PostDecodeWellKnownAttributes(boundAttributes, attributesToBind, diagnostics, symbolPart, wellKnownAttributeData); |
Member
There was a problem hiding this comment.
Why is it ok to move this from being unconditionally executed to only being executed if there's no matching filter? #Resolved
Contributor
Author
There was a problem hiding this comment.
Why is it ok to move this from being unconditionally executed to only being executed if there's no matching filter?
The only allowed side effect of this call is error reporting into diagnostics (from doc comment: "This method should not have any side effects on the symbol, i.e. it SHOULD NOT change the symbol state."), and this code path is the only code path that preserves the diagnostics.
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids infinite cycle in binding attributes for two or more different symbols.
Fixes #64392.