Skip to content

Improve GenerateMethod for VB implicit call case #64635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 2 commits into from
Oct 12, 2022
Merged

Improve GenerateMethod for VB implicit call case #64635

CyrusNajmabadi merged 2 commits into from
Oct 12, 2022

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Oct 11, 2022

Fixes #64631

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 11, 2022 17:11
@ghost ghost added the Area-IDE label Oct 11, 2022
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Oct 11, 2022

@ryzngard ptal. thanks!

@VBAndCs
Copy link

VBAndCs commented Oct 12, 2022

Thanks @CyrusNajmabadi

@runfoapp runfoapp bot mentioned this pull request Oct 12, 2022
Open
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Oct 12, 2022

@genlu can you ptal? tahnks!

ryzngard
ryzngard approved these changes Oct 12, 2022
View reviewed changes
...s/SharedUtilitiesAndExtensions/Compiler/VisualBasic/Extensions/ExpressionSyntaxExtensions.vb
' e.g. `WriteLine(SomeMethod)` is equivalent to `WriteLine(SomeMethod())`. So infer the return
' type of 'SomeMethod' here, not a delegate type for it.
'
' Note: this does not apply if teh user wrote `WriteLine(AddressOf SomeMethod)` of course.
Copy link
Contributor

@ryzngard ryzngard Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
' Note: this does not apply if teh user wrote `WriteLine(AddressOf SomeMethod)` of course.
' Note: this does not apply if the user wrote `WriteLine(AddressOf SomeMethod)` of course.

@CyrusNajmabadi CyrusNajmabadi merged commit c99037b into dotnet:main Oct 12, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the vbGenMethod branch October 12, 2022 21:48
@ghost ghost added this to the Next milestone Oct 12, 2022
@allisonchou allisonchou mentioned this pull request Oct 14, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@ryzngard ryzngard ryzngard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.5 P1

Development

Successfully merging this pull request may close these issues.

The generate method fix in VB generates a delegate param while AddressOf is not used

5 participants

@CyrusNajmabadi @VBAndCs @ryzngard @Youssef1313 @RikkiGibson