Revert: Revert "Set val escape on expression variables (#64414)" #64633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2ca2359.
ghost
added
the
RikkiGibson
approved these changes
Oct 11, 2022
| var variableSymbol = variableOpt switch | ||
| { | ||
| DeconstructionVariablePendingInference { VariableSymbol: var symbol } => symbol, | ||
| BoundLocal { DeclarationKind: BoundLocalDeclarationKind.WithExplicitType or BoundLocalDeclarationKind.WithInferredType, LocalSymbol: var symbol } => symbol, |
Member
There was a problem hiding this comment.
We have other cases where we check DeclarationKind: not BoundLocalDeclarationKind.None. In future we might want to be consistent here, or maybe introduce an extension/computed property which asks if the bound-local represents a user-visible variable declaration, which throws when an unknown DeclarationKind is encountered.
No need to change anything in this PR.
| // (34,9): error CS8350: This combination of arguments to 'R1.Deconstruct(out int, out R2)' is disallowed because it may expose variables referenced by parameter 'this' outside of their declaration scope | ||
| // r.Deconstruct(out var x4, out var y4); | ||
| Diagnostic(ErrorCode.ERR_CallArgMixing, "r.Deconstruct(out var x4, out var y4)").WithArguments("R1.Deconstruct(out int, out R2)", "this").WithLocation(34, 9)); | ||
| // (16,16): error CS8352: Cannot use variable 'y1' in this context because it may expose referenced variables outside of their declaration scope |
Member
There was a problem hiding this comment.
nit: consider indenting this to match the previous test baseline
Contributor
Author
There was a problem hiding this comment.
I'll update the indenting in a follow-up PR, unless other changes are needed in this PR.
Member
|
The second commit needs a second review. |
jaredpar
approved these changes
Oct 11, 2022
RikkiGibson
added a commit
to RikkiGibson/roslyn
that referenced
this pull request
Oct 11, 2022
Revert: Revert "Set val escape on expression variables (dotnet#64414)" Co-authored-by: Rikki Gibson <rigibson@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Revert: Revert "Set val escape on expression variables (#64414)"
Commit 2: Update escape analysis to ignore local declarations only.