Skip to content

Revert "Revert "Implement IAttributeOperation (#59369)"" #64488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
333fred merged 1 commit into from
Oct 12, 2022
Merged

Revert "Revert "Implement IAttributeOperation (#59369)"" #64488

333fred merged 1 commit into from
Oct 12, 2022

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Oct 4, 2022

Reverts #63485. Draft for now while I work on suppressing false positives in the VS repo.

@ghost ghost added the Area-Compilers label Oct 4, 2022
@333fred
Copy link
Member Author

333fred commented Oct 4, 2022 •
edited by JoeRobich
Loading

Insertion test pipeline: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6781458&view=results
Insertion PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/427752

@runfoapp runfoapp bot mentioned this pull request Oct 6, 2022
Closed
@RikkiGibson RikkiGibson self-assigned this Oct 12, 2022
@333fred
Copy link
Member Author

333fred commented Oct 12, 2022

/azp run

@333fred 333fred marked this pull request as ready for review October 12, 2022 20:13
@333fred 333fred requested review from a team as code owners October 12, 2022 20:13
@333fred 333fred enabled auto-merge (squash) October 12, 2022 20:13
@azure-pipelines
Copy link

azure-pipelines bot commented Oct 12, 2022

Azure Pipelines successfully started running 4 pipeline(s).

@333fred
Copy link
Member Author

333fred commented Oct 12, 2022

We have a passing VS build, so retriggering tests to make sure nothing new is failing locally and hen we'll get this merged!

jcouv
jcouv approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks as original PR (#59369) was already reviewed and approved

@333fred 333fred merged commit e34e164 into main Oct 12, 2022
@ghost ghost added this to the Next milestone Oct 12, 2022
@333fred 333fred deleted the revert-63485-revert_iop branch October 12, 2022 22:58
@runfoapp runfoapp bot mentioned this pull request Oct 12, 2022
Open
@build-analysis build-analysis bot mentioned this pull request Oct 13, 2022
Closed
2 tasks
@allisonchou allisonchou mentioned this pull request Oct 14, 2022
Closed
@ryzngard ryzngard mentioned this pull request Oct 19, 2022
Merged
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
@sharwell sharwell mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcouv jcouv jcouv approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels

Area-Compilers

Projects

None yet

Milestone

17.5 P1

Development

Successfully merging this pull request may close these issues.

4 participants

@333fred @jcouv @RikkiGibson