Skip to content

Conversation

RikkiGibson
Copy link
Member

Closes #58640.

Please use the "ignore whitespace" option when reviewing.

@RikkiGibson RikkiGibson requested a review from a team as a code owner January 27, 2022 18:47
@ghost ghost added the Area-Compilers label Jan 27, 2022
@RikkiGibson
Copy link
Member Author

@dotnet/roslyn-compiler for second review.

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@RikkiGibson RikkiGibson merged commit 674f7d4 into dotnet:main Jan 28, 2022
@ghost ghost added this to the Next milestone Jan 28, 2022
@RikkiGibson RikkiGibson deleted the nullable-static-partial branch January 28, 2022 19:02
333fred added a commit to YairHalberstadt/roslyn that referenced this pull request Jan 28, 2022
…ess-instance-members

* upstream/main: (669 commits)
  Fix 'hasStaticConstructor' check in MethodCompiler (dotnet#59116)
  Update dependencies from https://github.com/dotnet/arcade build 20220127.8 (dotnet#59134)
  Update StreamJsonRpc (dotnet#59073)
  Resources
  Filter cancellation exceptions in generator driver (dotnet#58843)
  Revert "Remove dependency on EditorFeatures from Remote.ServiceHub project (dotnet#59059)"
  Strings
  Inline
  Convert to switch expression
  Explicitly test empty string case.
  Fix comment
  Simplify test code
  Run all
  Add tests
  Delete test generator
  Add support for specifying server in tests
  Remove options
  review feedback
  Format document after each provider (dotnet#59091)
  [main] Update dependencies from dotnet/arcade (dotnet#59015)
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C#: erroneus CS8618 warning with partial class when definition is in one file and initialization in another

4 participants