CS1591 Thinks "protected" is public

[RadicalErin]

The error message around CS1591 ["missing xml comment for publicly visible type or member"] describes the item the warning relates to as "publicly visible". It also activates on protected members. I'm not sure if it is entirely desired or not, for the warning to throw on protected members. If not, then it is occurring unintentionally. If so, then the message is a bit inaccurate. It might also be nice to be able to configure whether CS1591 triggers for private/protected items, or not.

Version Used:
.Net 6.0
Compiler version: 4.6.0-3.23259.8 (c3cc1d0c)
Language version: 10.0

Steps to Reproduce:

1. Ensure that the documentation file option is set.
2. Create a class containing a protected member, and do not provide XML comment blocks for protected member(s).
3. If relevant, do not disable CS1591 around these members

Diagnostic Id:
CS1591

Expected Behavior:
Either no warning about comments [CS1591], because protected is not publicly visible, or if it is desired because of inheritance, a clearer message.

Actual Behavior:
Warning that describes the item as "publicly visible"

[Youssef1313]

The warning looks correct to me. The protected members are publicly visible. The word "publicly" here doesn't really mean the public modifier, but it means it's visible to the outer world (outside of the assembly containing it)

[RadicalErin]

I can see the thinking behind that. I think maybe the word "publicly" might be better phrased as "externally", so that it's not tied to a magic word that means something very specific. I'd be curious to see what people think about that.