Extensions: Close some tracked follow-ups (#80527)

Author: Julien Couvreur

src/Compilers/CSharp/Portable/Binder/WithUsingNamespacesAndTypesBinder.cs

@@ -133,7 +133,6 @@ internal override void GetCandidateExtensionMembersInSingleBinder(ArrayBuilder<S
         {
             Debug.Assert(members.Count == 0);
 
-            // Tracked by https://github.com/dotnet/roslyn/issues/79440 : using directives, test this flag (see TestUnusedExtensionMarksImportsAsUsed)
             bool callerIsSemanticModel = originalBinder.IsSemanticModelBinder;
 
             // We need to avoid collecting multiple candidates for an extension declaration imported both through a namespace and a static class

src/Compilers/CSharp/Portable/CSharpResources.resx

@@ -8202,4 +8202,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
   <data name="ERR_ExplicitInterfaceMemberReturnTypeMismatch" xml:space="preserve">
     <value>'{0}': return type must be '{1}' to match implemented member '{2}'</value>
   </data>
+  <data name="ParameterRequiresTypeOrIdentifier" xml:space="preserve">
+    <value>ParameterSyntax requires either a type or an identifier.</value>
+  </data>
 </root>

src/Compilers/CSharp/Portable/Compiler/MethodCompiler.cs

@@ -1181,7 +1181,6 @@ forSemanticModel.Syntax is { } semanticModelSyntax &&
                                                             });
                             }
 
-                            // Tracked by https://github.com/dotnet/roslyn/issues/78957 : public API, Ensure we are not messing up relative order of events for extension members (with relation to events for enclosing types, etc.)
                             _compilation.EventQueue.TryEnqueue(new SymbolDeclaredCompilationEvent(
                                 _compilation, methodSymbol, semanticModelWithCachedBoundNodes));
                         }

src/Compilers/CSharp/Portable/Emitter/Model/MethodSymbolAdapter.cs

@@ -310,7 +310,6 @@ Cci.ITypeDefinition Cci.ITypeDefinitionMember.ContainingTypeDefinition
                     return synthesizedGlobalMethod.ContainingPrivateImplementationDetailsType;
                 }
 
-                // Tracked by https://github.com/dotnet/roslyn/issues/78827 : code quality, share logic with Cci.ITypeMemberReference.GetContainingType implementation?
                 if (AdaptedMethodSymbol is SynthesizedExtensionMarker marker)
                 {
                     return ((SourceMemberContainerTypeSymbol)AdaptedMethodSymbol.ContainingType.ContainingType).GetExtensionGroupingInfo().GetCorrespondingMarkerType(marker);

src/Compilers/CSharp/Portable/Emitter/Model/PropertySymbolAdapter.cs

@@ -221,7 +221,6 @@ ITypeDefinition ITypeDefinitionMember.ContainingTypeDefinition
             {
                 CheckDefinitionInvariant();
 
-                // Tracked by https://github.com/dotnet/roslyn/issues/78827 : code quality, share logic with Cci.ITypeMemberReference.GetContainingType implementation?
                 if (AdaptedPropertySymbol.GetIsNewExtensionMember())
                 {
                     var containingType = AdaptedPropertySymbol.ContainingType;
@@ -249,7 +248,6 @@ ITypeReference ITypeMemberReference.GetContainingType(EmitContext context)
         {
             CheckDefinitionInvariant();
 
-            // Tracked by https://github.com/dotnet/roslyn/issues/78827 : code quality, share logic with Cci.ITypeMemberReference.GetContainingType implementation in MethodSymbolAdapter?
             if (AdaptedPropertySymbol.GetIsNewExtensionMember())
             {
                 var containingType = AdaptedPropertySymbol.ContainingType;

src/Compilers/CSharp/Portable/Generated/CSharpSyntaxGenerator/CSharpSyntaxGenerator.SourceGenerator/Syntax.xml.Syntax.Generated.cs

@@ -13766,8 +13766,11 @@ public sealed partial class ParameterSyntax : BaseParameterSyntax
     internal ParameterSyntax(InternalSyntax.CSharpSyntaxNode green, SyntaxNode? parent, int position)
       : base(green, parent, position)
     {
+        Validate();
     }
 
+    private partial void Validate();
+
     /// <summary>Gets the attribute declaration list.</summary>
     public override SyntaxList<AttributeListSyntax> AttributeLists => new SyntaxList<AttributeListSyntax>(GetRed(ref this.attributeLists, 0));
 

src/Compilers/CSharp/Portable/Syntax/ParameterSyntax.cs

@@ -13,5 +13,13 @@ internal bool IsArgList
                 return this.Type == null && this.Identifier.ContextualKind() == SyntaxKind.ArgListKeyword;
             }
         }
+
+        private partial void Validate()
+        {
+            if (Type is null && Identifier.IsKind(SyntaxKind.None))
+            {
+                throw new System.ArgumentException(CSharpResources.ParameterRequiresTypeOrIdentifier);
+            }
+        }
     }
 }

src/Compilers/CSharp/Portable/Syntax/Syntax.xml

@@ -4342,7 +4342,7 @@
     </Field>
     <Field Name="Type" Type="TypeSyntax" Optional="true"/>
   </AbstractNode>
-  <Node Name="ParameterSyntax" Base="BaseParameterSyntax" SkipConvenienceFactories="true">
+  <Node Name="ParameterSyntax" Base="BaseParameterSyntax" SkipConvenienceFactories="true" HasValidate="true"> 
     <TypeComment>
       <summary>Parameter syntax.</summary>
     </TypeComment>
@@ -4357,9 +4357,8 @@
         <summary>Gets the modifier list.</summary>
       </PropertyComment>
     </Field>
-    <Field Name="Type" Type="TypeSyntax" Optional="true" Override="true"/>
+    <Field Name="Type" Type="TypeSyntax" Optional="true" RequiredForTest="true" Override="true"/>
     <Field Name="Identifier" Type="SyntaxToken" Optional="true">
-      <!-- Tracked by https://github.com/dotnet/roslyn/issues/78961 : enforce that a ParameterSyntax cannot be created with both Type and Identifier missing -->
       <PropertyComment>
         <summary>Gets the identifier.</summary>
       </PropertyComment>

src/Compilers/CSharp/Portable/Syntax/SyntaxKindFacts.cs

@@ -853,7 +853,6 @@ public static SyntaxKind GetBaseTypeDeclarationKind(SyntaxKind kind)
             return kind == SyntaxKind.EnumKeyword ? SyntaxKind.EnumDeclaration : GetTypeDeclarationKind(kind);
         }
 
-        // Tracked by https://github.com/dotnet/roslyn/issues/78957 : public API, decide what we want for extension declaration
         public static SyntaxKind GetTypeDeclarationKind(SyntaxKind kind)
         {
             switch (kind)
@@ -866,6 +865,8 @@ public static SyntaxKind GetTypeDeclarationKind(SyntaxKind kind)
                     return SyntaxKind.InterfaceDeclaration;
                 case SyntaxKind.RecordKeyword:
                     return SyntaxKind.RecordDeclaration;
+                case SyntaxKind.ExtensionKeyword:
+                    return SyntaxKind.ExtensionBlockDeclaration;
                 default:
                     return SyntaxKind.None;
             }