[main] Source code updates from dotnet/dotnet (#79483)

[main] Source code updates from dotnet/dotnet


 - Workaround cref resolve issue due to new RuntimeHelpers in SCI

Author: dotnet-maestro[bot]

eng/Version.Details.xml

@@ -1,15 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Dependencies>
-  <Source Uri="https://github.com/dotnet/dotnet" Mapping="roslyn" Sha="f451e5d3036a4f140a989e0a7f3f1ae432420e71" BarId="274568" />
+  <Source Uri="https://github.com/dotnet/dotnet" Mapping="roslyn" Sha="96ac952a7886b565e83acc4c9cef656954ed0686" BarId="276277" />
   <ProductDependencies>
     <!-- RoslynAnalyzers reference older builds of Roslyn and this is necessary for SourceBuild. -->
     <Dependency Name="Microsoft.CodeAnalysis" Version="3.11.0">
       <Uri>https://github.com/dotnet/roslyn</Uri>
       <Sha>ae1fff344d46976624e68ae17164e0607ab68b10</Sha>
     </Dependency>
-    <Dependency Name="System.CommandLine" Version="2.0.0-beta5.25210.1">
-      <Uri>https://github.com/dotnet/command-line-api</Uri>
-      <Sha>e9b0511d7f1128e2bc3be7a658a2a4ea977e602d</Sha>
+    <Dependency Name="System.CommandLine" Version="2.0.0-beta7.25372.103">
+      <Uri>https://github.com/dotnet/dotnet</Uri>
+      <Sha>96ac952a7886b565e83acc4c9cef656954ed0686</Sha>
     </Dependency>
     <!-- Necessary for source-build. This allows the live version of the package to be used by source-build. -->
     <Dependency Name="Microsoft.Bcl.AsyncInterfaces" Version="9.0.0">

eng/Versions.props

@@ -48,7 +48,7 @@
     Versions managed by Arcade (see Versions.Details.xml)
   -->
   <PropertyGroup>
-    <SystemCommandLineVersion>2.0.0-beta5.25210.1</SystemCommandLineVersion>
+    <SystemCommandLineVersion>2.0.0-beta7.25372.103</SystemCommandLineVersion>
     <SystemCompositionVersion>9.0.0</SystemCompositionVersion>
     <SystemConfigurationConfigurationManagerVersion>9.0.0</SystemConfigurationConfigurationManagerVersion>
     <SystemDiagnosticsEventLogVersion>9.0.0</SystemDiagnosticsEventLogVersion>

src/Dependencies/Contracts/ReferenceEqualityComparer.cs

@@ -40,16 +40,18 @@ private ReferenceEqualityComparer() { }
     /// </remarks>
     public new bool Equals(object? x, object? y) => ReferenceEquals(x, y);
 
+#pragma warning disable CA1200 // Avoid using cref tags with a prefix - this works around cref not correctly resolving RuntimeHelpers as SCI also has an internal version without GetHashCode.
     /// <summary>
     /// Returns a hash code for the specified object. The returned hash code is based on the object
     /// identity, not on the contents of the object.
     /// </summary>
     /// <param name="obj">The object for which to retrieve the hash code.</param>
     /// <returns>A hash code for the identity of <paramref name="obj"/>.</returns>
     /// <remarks>
-    /// This API is a wrapper around <see cref="RuntimeHelpers.GetHashCode(object)"/>.
+    /// This API is a wrapper around <see cref="M:System.Runtime.CompilerServices.RuntimeHelpers.GetHashCode(object)"/>.
     /// It is not necessarily equivalent to calling <see cref="object.GetHashCode()"/>.
     /// </remarks>
+#pragma warning restore CA1200
     public int GetHashCode(object? obj)
     {
         // Depending on target framework, RuntimeHelpers.GetHashCode might not be annotated

src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs

@@ -32,8 +32,15 @@
 
 WindowsErrorReporting.SetErrorModeOnWindows();
 
-var parser = CreateCommandLineParser();
-return await parser.Parse(args).InvokeAsync(CancellationToken.None);
+var command = CreateCommand();
+var invocationConfiguration = new InvocationConfiguration()
+{
+    // By default, System.CommandLine will catch all exceptions, log them to the console, and return a non-zero exit code.
+    // Unfortunately this makes .NET's crash dump collection environment variables (e.g. 'DOTNET_DbgEnableMiniDump')
+    // entirely useless as it never detects an actual crash.  Disable this behavior so we can collect crash dumps when asked to.
+    EnableDefaultExceptionHandler = false
+};
+return await command.Parse(args).InvokeAsync(invocationConfiguration, CancellationToken.None);
 
 static async Task RunAsync(ServerConfiguration serverConfiguration, CancellationToken cancellationToken)
 {
@@ -167,7 +174,7 @@ static async Task RunAsync(ServerConfiguration serverConfiguration, Cancellation
     }
 }
 
-static CommandLineConfiguration CreateCommandLineParser()
+static RootCommand CreateCommand()
 {
     var debugOption = new Option<bool>("--debug")
     {
@@ -294,15 +301,7 @@ static CommandLineConfiguration CreateCommandLineParser()
         return RunAsync(serverConfiguration, cancellationToken);
     });
 
-    var config = new CommandLineConfiguration(rootCommand)
-    {
-        // By default, System.CommandLine will catch all exceptions, log them to the console, and return a non-zero exit code.
-        // Unfortunately this makes .NET's crash dump collection environment variables (e.g. 'DOTNET_DbgEnableMiniDump')
-        // entirely useless as it never detects an actual crash.  Disable this behavior so we can collect crash dumps when asked to.
-        EnableDefaultExceptionHandler = false
-    };
-
-    return config;
+    return rootCommand;
 }
 
 static (string clientPipe, string serverPipe) CreateNewPipeNames()

src/RoslynAnalyzers/Tools/GenerateDocumentationAndConfigFiles/Program.cs

@@ -257,7 +257,7 @@ public static Task<int> Main(string[] args)
                 return HandleAsync(commandLineArgs, cancellationToken);
             });
 
-            return rootCommand.Parse(args).InvokeAsync(CancellationToken.None);
+            return rootCommand.Parse(args).InvokeAsync(null, CancellationToken.None);
         }
 
         private static async Task<int> HandleAsync(CommandLineArgs args, CancellationToken cancellationToken)