Skip to content

Commit d57cddb

Browse files
mavasanimavasani
authored
Merge pull request #49995 from mavasani/PassEnforceOnBuild
Set EnforceOnBuild values for code style analyzers
2 parents ad294e9 + 8c876a0 commit d57cddb

File tree

99 files changed

+329
-53
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+329
-53
lines changed

‎src/Analyzers/CSharp/Analyzers/AddBraces/CSharpAddBracesDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ internal sealed class CSharpAddBracesDiagnosticAnalyzer :
2222
{
2323
public CSharpAddBracesDiagnosticAnalyzer()
2424
: base(IDEDiagnosticIds.AddBracesDiagnosticId,
25+
EnforceOnBuildValues.AddBraces,
2526
CSharpCodeStyleOptions.PreferBraces,
2627
LanguageNames.CSharp,
2728
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Add_braces), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),

‎src/Analyzers/CSharp/Analyzers/ConvertSwitchStatementToExpression/ConvertSwitchStatementToExpressionDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ internal sealed partial class ConvertSwitchStatementToExpressionDiagnosticAnalyz
2222
{
2323
public ConvertSwitchStatementToExpressionDiagnosticAnalyzer()
2424
: base(IDEDiagnosticIds.ConvertSwitchStatementToExpressionDiagnosticId,
25+
EnforceOnBuildValues.ConvertSwitchStatementToExpression,
2526
CSharpCodeStyleOptions.PreferSwitchExpression,
2627
LanguageNames.CSharp,
2728
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Convert_switch_statement_to_expression), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),

‎src/Analyzers/CSharp/Analyzers/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ internal class CSharpInlineDeclarationDiagnosticAnalyzer : AbstractBuiltInCodeSt
3636

3737
public CSharpInlineDeclarationDiagnosticAnalyzer()
3838
: base(IDEDiagnosticIds.InlineDeclarationDiagnosticId,
39+
EnforceOnBuildValues.InlineDeclaration,
3940
CSharpCodeStyleOptions.PreferInlinedVariableDeclaration,
4041
LanguageNames.CSharp,
4142
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Inline_variable_declaration), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),

‎src/Analyzers/CSharp/Analyzers/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ internal class InvokeDelegateWithConditionalAccessAnalyzer : AbstractBuiltInCode
2727
{
2828
public InvokeDelegateWithConditionalAccessAnalyzer()
2929
: base(IDEDiagnosticIds.InvokeDelegateWithConditionalAccessId,
30+
EnforceOnBuildValues.InvokeDelegateWithConditionalAccess,
3031
CSharpCodeStyleOptions.PreferConditionalDelegateCall,
3132
LanguageNames.CSharp,
3233
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Delegate_invocation_can_be_simplified), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)))

‎src/Analyzers/CSharp/Analyzers/MakeLocalFunctionStatic/MakeLocalFunctionStaticDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ internal class MakeLocalFunctionStaticDiagnosticAnalyzer : AbstractBuiltInCodeSt
1717
{
1818
public MakeLocalFunctionStaticDiagnosticAnalyzer()
1919
: base(IDEDiagnosticIds.MakeLocalFunctionStaticDiagnosticId,
20+
EnforceOnBuildValues.MakeLocalFunctionStatic,
2021
CSharpCodeStyleOptions.PreferStaticLocalFunction,
2122
LanguageNames.CSharp,
2223
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Make_local_function_static), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),

‎src/Analyzers/CSharp/Analyzers/MakeStructFieldsWritable/CSharpMakeStructFieldsWritableDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ internal sealed class CSharpMakeStructFieldsWritableDiagnosticAnalyzer : Abstrac
1818
{
1919
private static readonly DiagnosticDescriptor s_diagnosticDescriptor = CreateDescriptor(
2020
IDEDiagnosticIds.MakeStructFieldsWritable,
21+
EnforceOnBuildValues.MakeStructFieldsWritable,
2122
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Make_readonly_fields_writable), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
2223
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Struct_contains_assignment_to_this_outside_of_constructor_Make_readonly_fields_writable), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
2324
isUnnecessary: false);

‎src/Analyzers/CSharp/Analyzers/MisplacedUsingDirectives/MisplacedUsingDirectivesDiagnosticAnalyzer.cs‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,17 @@ internal sealed class MisplacedUsingDirectivesDiagnosticAnalyzer : AbstractBuilt
2727
nameof(CSharpAnalyzersResources.Using_directives_must_be_placed_outside_of_a_namespace_declaration), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources));
2828

2929
private static readonly DiagnosticDescriptor s_outsideDiagnosticDescriptor = CreateDescriptorWithId(
30-
IDEDiagnosticIds.MoveMisplacedUsingDirectivesDiagnosticId, s_localizableTitle, s_localizableOutsideMessage);
30+
IDEDiagnosticIds.MoveMisplacedUsingDirectivesDiagnosticId,
31+
EnforceOnBuildValues.MoveMisplacedUsingDirectives,
32+
s_localizableTitle, s_localizableOutsideMessage);
3133

3234
private static readonly LocalizableResourceString s_localizableInsideMessage = new(
3335
nameof(CSharpAnalyzersResources.Using_directives_must_be_placed_inside_of_a_namespace_declaration), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources));
3436

3537
private static readonly DiagnosticDescriptor s_insideDiagnosticDescriptor = CreateDescriptorWithId(
36-
IDEDiagnosticIds.MoveMisplacedUsingDirectivesDiagnosticId, s_localizableTitle, s_localizableInsideMessage);
38+
IDEDiagnosticIds.MoveMisplacedUsingDirectivesDiagnosticId,
39+
EnforceOnBuildValues.MoveMisplacedUsingDirectives,
40+
s_localizableTitle, s_localizableInsideMessage);
3741

3842
public MisplacedUsingDirectivesDiagnosticAnalyzer()
3943
: base(ImmutableDictionary<DiagnosticDescriptor, ILanguageSpecificOption>.Empty

‎src/Analyzers/CSharp/Analyzers/RemoveConfusingSuppression/CSharpRemoveConfusingSuppressionDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ internal sealed class CSharpRemoveConfusingSuppressionDiagnosticAnalyzer : Abstr
1515
{
1616
public CSharpRemoveConfusingSuppressionDiagnosticAnalyzer()
1717
: base(IDEDiagnosticIds.RemoveConfusingSuppressionForIsExpressionDiagnosticId,
18+
EnforceOnBuildValues.RemoveConfusingSuppressionForIsExpression,
1819
option: null,
1920
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Remove_unnecessary_suppression_operator), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
2021
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Suppression_operator_has_no_effect_and_can_be_misinterpreted), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)))

‎src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryDiscardDesignation/CSharpRemoveUnnecessaryDiscardDesignationDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ internal sealed class CSharpRemoveUnnecessaryDiscardDesignationDiagnosticAnalyze
1919
{
2020
public CSharpRemoveUnnecessaryDiscardDesignationDiagnosticAnalyzer()
2121
: base(IDEDiagnosticIds.RemoveUnnecessaryDiscardDesignationDiagnosticId,
22+
EnforceOnBuildValues.RemoveUnnecessaryDiscardDesignation,
2223
option: null,
2324
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Remove_unnessary_discard), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
2425
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Discard_can_be_removed), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),

‎src/Analyzers/CSharp/Analyzers/RemoveUnreachableCode/CSharpRemoveUnreachableCodeDiagnosticAnalyzer.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ internal class CSharpRemoveUnreachableCodeDiagnosticAnalyzer : AbstractBuiltInCo
2626

2727
public CSharpRemoveUnreachableCodeDiagnosticAnalyzer()
2828
: base(IDEDiagnosticIds.RemoveUnreachableCodeDiagnosticId,
29+
EnforceOnBuildValues.RemoveUnreachableCode,
2930
option: null,
3031
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Unreachable_code_detected), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
3132
// This analyzer supports fading through AdditionalLocations since it's a user-controlled option

0 commit comments

Comments
 (0)