Skip to content

Commit d5554f3

Browse files
333fredCyrusNajmabadidavidwengierDoctorKrolicAlekseyTs
authored
Merge main (#79424)
* Simplify code * Simplify code * Ensure server is loaded and unloaded with the solution * Check that a resulting ternary operator conversion is implicit before removing a cast in one of its branches * Extract method for handling source generated documents * Revert "Remove the 'intent' subsystem from roslyn (#79179)" This reverts commit 4e03ac9, reversing changes made to 93b1b3e. * Remove legacy intents that are no longer hooked up * Remove unnecessary folder in project file * More cases * More cases * remove tests * Reduce allocations of BoundBinaryOperator.UncommonData (#79200) * Remove duplicate method * Extensions: adjust SpecialName on implementation methods (#79068) * Update azure-pipelines-integration-dartlab.yml (#79206) * Rename * Remove obsolete code * Extract common lexer code into helpers (#79214) * Improve diagnostic for ambiguous predefined type (#79196) * Improve diagnostic for ambiguous predefined type * Update pre-existing tests * Keep translations * Revert unnecessary changes * Add a source package that can be used to connect to the roslyn build server (#78986) * Add BuildClient package * Allow sdk passing compiler hash * Reuse in Replay * Add a bit how we can and will break the APIs * Move more files to the shared folder * Use shared file list in build task * Address some known functionality gaps for extension operators (#79167) Related to #78968. Related to #76130. * Use spans in low level lexer char array handling code * Use spans in low level lexer char array handling code * VB tests * Remove duplicate code for processing arrays vs strings * Revert * Fix test * Add internal APIs for prototyping * Share more code * Remove unused function * Use spans in low level lexer char array handling code (#79232) * Remove unused functions (#79234) * Update src/Compilers/Core/Portable/InternalUtilities/StringTable.cs * Remove using * Rename FileBasedProgramsProjectFactory to MiscellaneousFilesWorkspaceProjectFactory * Don't double register for document sync * Don't check configuration if the client doesn't support it (ie, tests) * Extensions: adjust logic related to primary ctor parameter (#79056) * Address another set of functionality gaps for extension operators (#79227) Related to #78967 Related to #78968 Related to #76130 * Revert "Use spans in low level lexer char array handling code (#79232)" (#79245) This reverts commit fb38d6b. * Use spans in low level lexer char array handling code (part 2) (#79250) * Allow the Razor extension to report telemetry (and initialize) * Make the new Workspace.Register*Handler methods public We're obsoleting the old ones since the expectation going forward is most users can use the new ones only. * Do not use a constructed method symbol in a BoundMethodDefIndex (#79211) * Simplify * Address follow-up comments for extension operators (#79249) Closes #79136. * Use collection expression * Docs * ordering * Initial support for adding obsolete attributes to primary constructors * Flesh out * Use raw strings * File scoped namespaces * Simplify tests * in progress * Simpler approach * Revert * Simplify tests * Working * Delete file * Remove file * Use the miscellaneous files project name for rich misc projects (#79267) * Update tests * Inline strings in test code * Make tests non-async * Add the "experimental feature" string back Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2453154 * Move telemetry initialization out of our UI-thread bound helper This isn't needed anymore. * Update global.json * Update nuget.config * Update Arcade * Use .NET 10 Preview 5 SDK * Add back dotnet9 feed * Add back additional feeds * Add back dotnet6 feed * The Unix CI build does not need to pack or publish * Downgrade arcade * Reapply "Move to .NET 10 Preview 5 (#78906)" This reverts commit 1ab27c2. * Use scouting queue for integration tests * Revert: Use scouting queue for integration tests * Fix Rename adornment positioning after scrolling * Fix debugging of build tasks (#78271) * Fix debugging of build tasks * Split into a new target * Fix up tests * Tweak 'add required parens' to recognize a common C# idiom * Lint * Revert compiler change (#79288) * Extensions: extension grouping type names (#79217) * Fix ref safety of user-defined increment operators (#79034) * Fix ref safety of user-defined increment operators * Update after merge * Improve code and tests * Inline test code * Make tests synchronous * Remove unnecessary await * Enable C# classification in more tests * Fix unit tests There's two issues here: 1. Some tests of the VS layer didn't have the telemetry service in the first place. 2. There was now a circularity between the VisualStudioWorkspace and VisualStudioWorkspaceTelemetryService, so a Lazy has been added. * Use collection expressions * Explicitly document that ITaggerEventSource.Changed can be on any thread All subscribers are working in thread-safe manners (they either take locks to clear caches, or use existing batching/threading primitives to queue new work). * Document that LspSolutionChanged may happen on any thread Subscribers were already thread safe. I've also removed the IMPORTANT warning since it seems quite stale -- this is already in a delayed queue so it's not really clear what it meant. * Remove subscription from WorkspaceChanged in the StackTraceExplorer I'm unable to figure out what the intent was here -- it clears the list but only on a SolutionChanged event, which is the type of event raised if multiple projects are modified at once in a single workspace change -- any other type of event would have a more specific kind. I could imagine the intent might have been for solution close, but then I can imagine scenarios where the user might have pasted a stack and now needs to switch the solution to navigate from the stack. Since this likely never ran, I'm just deleting it. * Avoid checking the CanonicalName each time for the analyzer If the user expands a node in a CPS project wanting to look at the diagnostics under an analyzer, but we haven't been told about that analyzer let, we stick a WorkspaceChanged handler there to find it once it comes back. We were hopping to the UI thread to see if the CanonicalName of the item could have changed, but that's not really going to happen ever for these items, so we can just grab it once during creation and be done with it. * Remove thread requirement from CodeAnalysisDiagnosticAnalyzerService This looks to be safely callable from any thread. * Reduce probability of stack overflow during exception handling in ModelComputation (#79292) Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2428510 This was previously addressed by adding a Task.Yield to the TransformModelAsync execution, instead this moves that stack size mitigation to the exception handling process. Per #26567, the vast majority of stack size during stack unwinding is due to the unwinding process itself. * Remove synchronous rename (#78839) * wip * wip * wip * fix tests * wip * remove unused code * update test impl * update option test * add cancel method * some cleanup * call CommitAsync in tests instead * fix some comments and naming * rename commit to make it more clear it's an async operation * feedback * feedback * fix integration test * Update * Add test demonstrating issue * inline * fix casing mismatch when using non-unc file paths * Collection expressions * Skip failing tests * Add cookbook section for avoiding inheritance (#79276) * Add cookbook section for avoiding inheritance Adds a section to the incremental generators cookbook on why users should avoid inheritance, that goes over a few possible scenarios and how they can hurt IDE responsiveness. * Update ToC * Add a small note on preferring FAWMN. * Make 'convert to raw string' a syntax-only refactoring * Fix issue with use-raw-string and fix-all * Fix bad merge * Use raw strings in tests * [main] Source code updates from dotnet/dotnet (#79313) * [VMR] Codeflow 9eec48b-9eec48b [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 274568 No dependency updates to commit --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix argument indentation * REvert * Simplify initialization of OpenFileTracker There's only two things here that could potentially need the UI thread: 1. The Running Document Table subscription, but OpenTextBufferProvider already abstracted that away. 2. The IEditorOptionsFactoryService usage, which being a MEF component shouldn't care, but even then we don't need it right away. It's easy to clean all this up, so just do so. * Revert * revise * NRT * Auto prop * nrt * Fix * Update src/Compilers/Core/Portable/AdditionalTextFile.cs * better fix * better fix * better fix * Set DeployExtension for all the extensions we expect to deploy * Set RoslynCompilerType=Custom in all toolset package flavors (#79327) * Fix code gen for some increment/compound assignment scenarios involving constrained calls. (#79293) Fixes #79268 * In progress * In progress * Hook up * Add work item * Cleanup * Simplify * Update to xunit.runner.visualstudio 3.1.1 Address changes from dotnet/sdk#49248. * Temporarily increase timeout of helix items to see if it resolves timeouts * Update resx generator test resources to assert new behavior, and fix generator in one instance * Revert broken raw string changes in PropertySetAnalysisTests * Fix 'use var' with spans * Skip tests affected by dotnet/runtime#117566. * Disable tests for #79351 * Disable tests for #79352. * Make tests more consistent * Fix issue offering to remove nullable cast in a ternary expression * Fix not offering to remove unnecessary nullable pragmas * Fix issue with remove unnecessary parens in vb * Fix crash in replace property with methods * Fix * Track assembly names, not counts * Disable more tests for #79352 * Add test * Add test showing issue no longer reproes * Fix issue where typeof/sizeof weren't classified properly in FindRefs * Allow user to still create a new field/prop when offering to initialize an existing prop * Ensure generated types come after top level statements * Null tolerance * Ensure we collect dumps on hangs/crashes * nrt * Update configs for snap * *** DO NOT MERGE: Revert "Remove most remaining uses of WorkspaceChanged off the UI thread (#78778)" (#79366) This reverts commit 67cce50, reversing changes made to aafd6eb. Going to run a test insertion to see if this is the cause of regressions flagged in https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/650773 * Disable Assert that is causing hangs Will follow up with an issue but disabling for now to see if this unblocks the CoreCLR tests * Add console logger to ensure helix console log has detailed info * Replace Assert.False call This `Assert.False` call was executing directly an a thread pool thread. That meant when it triggered it was an unhandled exception on a TPT which crashes the process. The calling code already fails the test when this happen hence changed this to just output the failure info to the test logs. * Fix helix timeout * Use new dll name for hooking xunit dispose --------- Co-authored-by: Cyrus Najmabadi <cyrusn@microsoft.com> Co-authored-by: David Wengier <david.wengier@microsoft.com> Co-authored-by: DoctorKrolic <mapmyp03@gmail.com> Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Co-authored-by: AlekseyTs <AlekseyTs@users.noreply.github.com> Co-authored-by: Julien Couvreur <julien.couvreur@gmail.com> Co-authored-by: Ankita Khera <40616383+akhera99@users.noreply.github.com> Co-authored-by: Jan Jones <janjones@microsoft.com> Co-authored-by: gel@microsoft.com <gel@microsoft.com> Co-authored-by: Jason Malinowski <jason.malinowski@microsoft.com> Co-authored-by: Gen Lu <genlu@users.noreply.github.com> Co-authored-by: Rikki Gibson <rigibson@microsoft.com> Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com> Co-authored-by: Joey Robichaud <jorobich@microsoft.com> Co-authored-by: Oleg Tkachenko <olegtk@microsoft.com> Co-authored-by: Todd Grunke <toddgrun@microsoft.com> Co-authored-by: David Barbet <dabarbet@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: jaredpar <jared@paranoidcoding.org>
2 parents 7de7718 + 0f7d644 commit d5554f3

File tree

4,271 files changed

+276710
-306529
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

4,271 files changed

+276710
-306529
lines changed

.github/ISSUE_TEMPLATE/bug-report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ about: Report a bug in Roslyn
1111
2.
1212
3.
1313

14-
A minimal repro, with source-code provided, is ideal. Most compiler/language issues can be distilled into a snippet that can be pasted into [sharplab](https://sharplab.io/).
14+
A minimal repro, with source-code provided, is ideal. Most compiler/language issues can be distilled into a snippet that can be pasted into [.NET Lab](https://lab.razor.fyi/#csharp).
1515

1616
**Diagnostic Id**:
1717

.vscode/tasks.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
"command": "dotnet",
104104
"args": [
105105
"build",
106+
"-p:InnerTargets=CopyFilesForDebugging",
106107
"-p:GenerateFullPaths=true",
107108
"${workspaceFolder}/src/NuGet/Microsoft.Net.Compilers.Toolset/AnyCpu/Microsoft.Net.Compilers.Toolset.Package.csproj"
108109
],

Compilers.slnf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
"src\\ExpressionEvaluator\\Core\\Source\\ExpressionCompiler\\Microsoft.CodeAnalysis.ExpressionCompiler.csproj",
5454
"src\\ExpressionEvaluator\\VisualBasic\\Source\\ExpressionCompiler\\Microsoft.CodeAnalysis.VisualBasic.ExpressionCompiler.vbproj",
5555
"src\\Interactive\\csi\\csi.csproj",
56+
"src\\NuGet\\Microsoft.CodeAnalysis.BuildClient.Package\\Microsoft.CodeAnalysis.BuildClient.Package.csproj",
5657
"src\\NuGet\\Microsoft.CodeAnalysis.Compilers.Package\\Microsoft.CodeAnalysis.Compilers.Package.csproj",
5758
"src\\NuGet\\Microsoft.CodeAnalysis.Package\\Microsoft.CodeAnalysis.Package.csproj",
5859
"src\\NuGet\\Microsoft.Net.Compilers.Toolset\\AnyCpu\\Microsoft.Net.Compilers.Toolset.Package.csproj",

NuGet.config

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@
55
<clear />
66
<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
77
<add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
8+
<!-- We need dotnet6 because BuildValidator depends on runtime.{platform}.Microsoft.NETCore.ILDAsm (>= 6.0.0-rtm.21518.12) -->
89
<add key="dotnet6" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json" />
9-
<add key="dotnet7" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json" />
10+
<!-- We need dotnet7-transport because we depend on Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers (>= 3.3.4-beta1.22504.1) -->
1011
<add key="dotnet7-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7-transport/nuget/v3/index.json" />
12+
<!-- We need dotnet8 because we depend on Microsoft.CodeAnalysis.NetAnalyzers (>= 8.0.0-preview.23468.1) -->
1113
<add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />
12-
<add key="dotnet8-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8-transport/nuget/v3/index.json" />
14+
<!-- We need dotnet9 because we depend on Roslyn.Diagnostics.Analyzers (>= 3.11.0-beta1.24081.1)-->
1315
<add key="dotnet9" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
14-
<add key="dotnet9-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9-transport/nuget/v3/index.json" />
16+
<add key="dotnet10" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10/nuget/v3/index.json" />
17+
<add key="dotnet10-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10-transport/nuget/v3/index.json" />
1518
<add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" />
1619
<add key="dotnet-libraries" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json" />
1720
<add key="dotnet-libraries-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries-transport/nuget/v3/index.json" />

Roslyn.sln

Lines changed: 93 additions & 26 deletions
Large diffs are not rendered by default.

azure-pipelines-integration-dartlab.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ resources:
2222
name: internal/dotnet-roslyn
2323
ref: $(Build.SourceBranch)
2424
trigger:
25-
- main
25+
- main-vs-deps
2626

2727
parameters:
2828
- name: prNumber
@@ -122,4 +122,4 @@ stages:
122122
gitHubConnection: 'dotnet-comment-bot-service-connection'
123123
repositoryName: '$(Build.Repository.Name)'
124124
id: ${{ parameters.prNumber }}
125-
comment: 'DartLab pipeline [run]($(System.TeamFoundationCollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId)) did not complete successfully for ${{ parameters.sha }}'
125+
comment: 'DartLab pipeline [run]($(System.TeamFoundationCollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId)) did not complete successfully for ${{ parameters.sha }}'

azure-pipelines-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ parameters:
6868
- name: queueName
6969
displayName: Queue Name
7070
type: string
71-
default: windows.vs2022preview.amd64.open
71+
default: windows.vs2022preview.scout.amd64.open
7272
values:
7373
- windows.vs2022.amd64.open
7474
- windows.vs2022.scout.amd64.open

docs/contributing/Compiler Test Plan.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ This document provides guidance for thinking about language interactions and tes
8080
- Readonly members on structs (methods, property/indexer accessors, custom event accessors)
8181
- SkipLocalsInit
8282
- Method override or explicit implementation with `where T : { class, struct, default }`
83-
- `extension` blocks
83+
- `extension` blocks (emitted with content-based names)
8484

8585
# Code
8686
- Operators (see Eric's list below)

docs/features/incremental-generators.cookbook.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ of scope in the final design of the shipping feature.
2121
- [Pipeline model design](#pipeline-model-design)
2222
- [Use `ForAttributeWithMetadataName`](#use-forattributewithmetadataname)
2323
- [Use an indented text writer, not `SyntaxNode`s, for generation](#use-an-indented-text-writer-not-syntaxnodes-for-generation)
24+
- [Put `Microsoft.CodeAnalysis.EmbeddedAttribute` on generated marker types](#put-microsoftcodeanalysisembeddedattribute-on-generated-marker-types)
25+
- [Do not scan for types that indirectly implement interfaces, indirectly inherit from types, or are indirectly marked by an attribute from an interface or base type](#do-not-scan-for-types-that-indirectly-implement-interfaces-indirectly-inherit-from-types-or-are-indirectly-marked-by-an-attribute-from-an-interface-or-base-type)
2426
- [Designs](#designs)
2527
- [Generated class](#generated-class)
2628
- [Additional file transformation](#additional-file-transformation)
@@ -135,6 +137,27 @@ project, it will not include that type in lookup results. To ensure that `Micros
135137
Another option is to provide an assembly in your nuget package that defines your marker attributes, but this can be more difficult to author. We recommend the
136138
`EmbeddedAttribute` approach, unless you need to support versions of Roslyn lower than 4.14.
137139

140+
### Do not scan for types that indirectly implement interfaces, indirectly inherit from types, or are indirectly marked by an attribute from an interface or base type
141+
142+
Using an interface/base type marker can be a very tempting and natural fit for generators. However, scanning for these types of markers is _very_ expensive, and cannot
143+
be done incrementally. Doing so can have an outsized impact on IDE and command-line performance, even for fairly small consuming users. These scenarios are:
144+
145+
* A user implements an interface on `BaseModelType`, and then the generator looks all derived types from `BaseModelType`. Because the generator cannot know ahead of time
146+
what `BaseModelType` actually is, it means that the generator has to fetch `AllInterfaces` on every single type in the compilation so it can scan for the marker
147+
interface. This will end up occurring either on every keystroke or every file save, depending on what mode the user is running generators in; either one is disastrous
148+
for IDE performance, even when trying to optimize by scoping down the scanning to only types with a base list.
149+
* A user inherits from a generator-defined `BaseSerializerType`, and the generator looks for anything that inherits from that type, either directly or indirectly. Similar
150+
to the above scenario, the generator will need to scan all types with a base type in the entire compilation for the inherited `BaseSerializerType`, which will heavily
151+
impact IDE performance.
152+
* A generator looks among all base types/implemented interfaces for a type that is attributed with a generator's marker attribute. This is effectively either scenario 1
153+
or 2, just with a different search criteria.
154+
* A generator leaves its marker attribute unsealed, and expects users to be able to derive their own attributes from that marker, as a source of parameter customization.
155+
This has a couple of problems: first, every attributed type needs to be checked to see if the attribute inherits from the marker attribute. While not as performance
156+
impacting as the first three scenarios, this isn't great for performance. Second, and more importantly, there is no good way to retrieve any customizations from the
157+
inherited attribute. These attributes are not instantiated by the source generator, so any parameters passed to the `base()` constructor call or values that are assigned
158+
to any properties of the base attribute are not visible to the generator. Prefer using FAWMN-driven development here, and using an analyzer to inform the user if they
159+
need to inherit from some base class for your generator to work correctly.
160+
138161
## Designs
139162

140163
This section is broken down by user scenarios, with general solutions listed first, and more specific examples later on.

eng/Directory.Packages.props

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@
199199
<PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="$(SystemRuntimeCompilerServicesUnsafeVersion)" />
200200
<PackageVersion Include="System.Security.Cryptography.ProtectedData" Version="$(SystemSecurityCryptographyProtectedDataVersion)" />
201201
<PackageVersion Include="System.Security.Permissions" Version="$(SystemSecurityPermissionsVersion)" />
202-
<PackageVersion Include="System.Text.Encoding.CodePages" Version="7.0.0" />
202+
<PackageVersion Include="System.Text.Encoding.CodePages" Version="8.0.0" />
203203
<PackageVersion Include="System.Threading.Tasks.Dataflow" Version="$(SystemThreadingTasksDataflowVersion)" />
204204
<PackageVersion Include="System.Threading.Tasks.Extensions" Version="$(SystemThreadingTasksExtensionsVersion)" />
205205
<PackageVersion Include="System.ValueTuple" Version="$(SystemValueTupleVersion)" />
@@ -215,7 +215,7 @@
215215
<PackageVersion Include="System.Text.Encodings.Web" Version="$(SystemTextEncodingsWebVersion)" />
216216
<!-- Note: When updating SystemTextJsonVersion ensure that the version is no higher than what is used by MSBuild. -->
217217
<PackageVersion Include="System.Text.Json" Version="$(SystemTextJsonVersion)" />
218-
<PackageVersion Include="System.Threading.Channels" Version="7.0.0" />
218+
<PackageVersion Include="System.Threading.Channels" Version="8.0.0" />
219219

220220
<PackageVersion Include="Microsoft.IO.Redist" Version="$(MicrosoftIORedistVersion)" />
221221

@@ -273,7 +273,7 @@
273273
<PackageVersion Include="xunit.core" Version="$(_xunitVersion)" />
274274
<PackageVersion Include="Xunit.Combinatorial" Version="1.6.24" />
275275
<PackageVersion Include="xunit.extensibility.core" Version="$(_xunitVersion)" />
276-
<PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5 " />
276+
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.1" />
277277
<PackageVersion Include="xunit.runner.utility" Version="$(_xunitVersion)" />
278278
<PackageVersion Include="xunit.abstractions" Version="2.0.3" />
279279
<PackageVersion Include="xunit.extensibility.execution" Version="$(_xunitVersion)" />
@@ -319,16 +319,16 @@
319319
but not higher than our minimum dogfoodable Visual Studio version, or else
320320
the generators we build would load on the command line but not load in IDEs.
321321
-->
322-
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.1.0" />
322+
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.12.0" />
323323
<!--
324324
The version of Roslyn used in the RoslynAnalyzers varies. These are defaults that
325325
will be overridden in the RoslynAnalyzer project files.
326326
-->
327-
<!--<PackageVersion Include="Microsoft.CodeAnalysis" Version="4.1.0" /> -->
328-
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.1.0" />
329-
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.1.0" />
330-
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic" Version="4.1.0" />
331-
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="4.1.0" />
332-
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.1.0" />
327+
<!--<PackageVersion Include="Microsoft.CodeAnalysis" Version="4.12.0" /> -->
328+
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.12.0" />
329+
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.12.0" />
330+
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic" Version="4.12.0" />
331+
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="4.12.0" />
332+
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.12.0" />
333333
</ItemGroup>
334334
</Project>

0 commit comments

Comments
 (0)