Use users settings as a starting point for Razor formatting

Author: davidwengier

src/EditorFeatures/Core/Options/LegacyGlobalOptionsWorkspaceService.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Composition;
 using Microsoft.CodeAnalysis.Formatting;
+using Microsoft.CodeAnalysis.Host;
 using Microsoft.CodeAnalysis.Host.Mef;
 
 namespace Microsoft.CodeAnalysis.Options;
@@ -63,4 +64,7 @@ public bool GetGenerateConstructorFromMembersOptionsAddNullChecks(string languag
 
     public void SetGenerateConstructorFromMembersOptionsAddNullChecks(string language, bool value)
         => _globalOptions.SetGlobalOption(s_addNullChecks, language, value);
+
+    public SyntaxFormattingOptions GetSyntaxFormattingOptions(LanguageServices languageServices)
+        => _globalOptions.GetSyntaxFormattingOptions(languageServices);
 }

src/Features/ExternalAccess/OmniSharp/InternalAPI.Unshipped.txt

@@ -213,6 +213,7 @@ Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOpt
 Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOptionsWorkspaceService.GetGenerateConstructorFromMembersOptionsAddNullChecks(string! language) -> bool
 Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOptionsWorkspaceService.GetGenerateEqualsAndGetHashCodeFromMembersGenerateOperators(string! language) -> bool
 Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOptionsWorkspaceService.GetGenerateEqualsAndGetHashCodeFromMembersImplementIEquatable(string! language) -> bool
+Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOptionsWorkspaceService.GetSyntaxFormattingOptions(Microsoft.CodeAnalysis.Host.LanguageServices! languageServices) -> Microsoft.CodeAnalysis.Formatting.SyntaxFormattingOptions!
 Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOptionsWorkspaceService.InlineHintsOptionsDisplayAllOverride.get -> bool
 Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOptionsWorkspaceService.InlineHintsOptionsDisplayAllOverride.set -> void
 Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Options.OmnisharpLegacyGlobalOptionsWorkspaceService.OmniSharpCleanCodeGenerationOptionsProvider

src/Features/ExternalAccess/OmniSharp/Options/OmnisharpLegacyGlobalOptionsWorkspaceService.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Composition;
 using Microsoft.CodeAnalysis.Formatting;
+using Microsoft.CodeAnalysis.Host;
 using Microsoft.CodeAnalysis.Host.Mef;
 using Microsoft.CodeAnalysis.Options;
 
@@ -54,5 +55,8 @@ public bool GetGenerateConstructorFromMembersOptionsAddNullChecks(string languag
         public void SetGenerateConstructorFromMembersOptionsAddNullChecks(string language, bool value)
         {
         }
+
+        public SyntaxFormattingOptions GetSyntaxFormattingOptions(LanguageServices languageServices)
+            => SyntaxFormattingOptions.CommonDefaults;
     }
 }

src/Tools/ExternalAccess/Razor/RazorCSharpFormattingInteractionService.cs

@@ -47,7 +47,7 @@ public static async Task<ImmutableArray<TextChange>> GetFormattingChangesAsync(
                 return ImmutableArray<TextChange>.Empty;
             }
 
-            var formattingOptions = GetFormattingOptions(indentationOptions);
+            var formattingOptions = GetFormattingOptions(document.Project.Solution.Services, indentationOptions);
             var roslynIndentationOptions = new IndentationOptions(formattingOptions)
             {
                 AutoFormattingOptions = autoFormattingOptions.UnderlyingObject,
@@ -65,7 +65,7 @@ public static IList<TextChange> GetFormattedTextChanges(
             CancellationToken cancellationToken)
         {
             Contract.ThrowIfFalse(root.Language is LanguageNames.CSharp);
-            return Formatter.GetFormattedTextChanges(root, span, services.SolutionServices, GetFormattingOptions(indentationOptions), cancellationToken);
+            return Formatter.GetFormattedTextChanges(root, span, services.SolutionServices, GetFormattingOptions(services.SolutionServices, indentationOptions), cancellationToken);
         }
 
         public static SyntaxNode Format(
@@ -75,19 +75,26 @@ public static SyntaxNode Format(
             CancellationToken cancellationToken)
         {
             Contract.ThrowIfFalse(root.Language is LanguageNames.CSharp);
-            return Formatter.Format(root, services.SolutionServices, GetFormattingOptions(indentationOptions), cancellationToken: cancellationToken);
+            return Formatter.Format(root, services.SolutionServices, GetFormattingOptions(services.SolutionServices, indentationOptions), cancellationToken: cancellationToken);
         }
 
-        private static SyntaxFormattingOptions GetFormattingOptions(RazorIndentationOptions indentationOptions)
-            => new CSharpSyntaxFormattingOptions()
+        private static SyntaxFormattingOptions GetFormattingOptions(SolutionServices services, RazorIndentationOptions indentationOptions)
+        {
+            var legacyOptionsService = services.GetService<ILegacyGlobalOptionsWorkspaceService>();
+            var formattingOptions = legacyOptionsService is null
+                ? new CSharpSyntaxFormattingOptions()
+                : legacyOptionsService.GetSyntaxFormattingOptions(services.GetLanguageServices(LanguageNames.CSharp));
+
+            return formattingOptions with
             {
-                LineFormatting = new()
+                LineFormatting = formattingOptions.LineFormatting with
                 {
                     UseTabs = indentationOptions.UseTabs,
                     TabSize = indentationOptions.TabSize,
                     IndentationSize = indentationOptions.IndentationSize,
                     NewLine = CSharpSyntaxFormattingOptions.Default.NewLine
                 }
             };
+        }
     }
 }

src/Workspaces/Core/Portable/Options/ILegacyGlobalOptionsWorkspaceService.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using Microsoft.CodeAnalysis.Formatting;
 using Microsoft.CodeAnalysis.Host;
 
 namespace Microsoft.CodeAnalysis.Options;
@@ -25,4 +26,6 @@ internal interface ILegacyGlobalOptionsWorkspaceService : IWorkspaceService
 
     public bool GetGenerateConstructorFromMembersOptionsAddNullChecks(string language);
     public void SetGenerateConstructorFromMembersOptionsAddNullChecks(string language, bool value);
+
+    SyntaxFormattingOptions GetSyntaxFormattingOptions(LanguageServices languageServices);
 }