Remove Validate from ParameterSyntax

Author: Julien Couvreur

src/Compilers/CSharp/Portable/Generated/CSharpSyntaxGenerator/CSharpSyntaxGenerator.SourceGenerator/Syntax.xml.Syntax.Generated.cs

@@ -13766,7 +13766,6 @@ public sealed partial class ParameterSyntax : BaseParameterSyntax
     internal ParameterSyntax(InternalSyntax.CSharpSyntaxNode green, SyntaxNode? parent, int position)
       : base(green, parent, position)
     {
-        Validate();
     }
 
     /// <summary>Gets the attribute declaration list.</summary>
@@ -13823,9 +13822,7 @@ public ParameterSyntax Update(SyntaxList<AttributeListSyntax> attributeLists, Sy
         {
             var newNode = SyntaxFactory.Parameter(attributeLists, modifiers, type, identifier, @default);
             var annotations = GetAnnotations();
-            var result = annotations?.Length > 0 ? newNode.WithAnnotations(annotations) : newNode;
-            result.Validate();
-            return result;
+            return annotations?.Length > 0 ? newNode.WithAnnotations(annotations) : newNode;
         }
 
         return this;

src/Compilers/CSharp/Portable/Syntax/ParameterSyntax.cs

@@ -13,13 +13,5 @@ internal bool IsArgList
                 return this.Type == null && this.Identifier.ContextualKind() == SyntaxKind.ArgListKeyword;
             }
         }
-
-        internal void Validate()
-        {
-            if (Type is null && Identifier.IsKind(SyntaxKind.None))
-            {
-                throw new System.NotSupportedException();
-            }
-        }
     }
 }

src/Compilers/CSharp/Portable/Syntax/Syntax.xml

@@ -4342,7 +4342,7 @@
     </Field>
     <Field Name="Type" Type="TypeSyntax" Optional="true"/>
   </AbstractNode>
-  <Node Name="ParameterSyntax" Base="BaseParameterSyntax" SkipConvenienceFactories="true" HasValidate="true"> 
+  <Node Name="ParameterSyntax" Base="BaseParameterSyntax" SkipConvenienceFactories="true">
     <TypeComment>
       <summary>Parameter syntax.</summary>
     </TypeComment>

src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs

@@ -34440,9 +34440,8 @@ static class E
         var withoutIdentifer = parameter.WithIdentifier(default);
         Assert.Equal("int ", withoutIdentifer.ToFullString());
 
-        // Type and identifier cannot both be missing
-        Assert.Throws<NotSupportedException>(() => SyntaxFactory.Parameter(identifier: default));
-        Assert.Throws<NotSupportedException>(() => withoutType.WithIdentifier(default));
+        Assert.Equal("", SyntaxFactory.Parameter(identifier: default).ToFullString());
+        Assert.Equal("", withoutType.WithIdentifier(default).ToFullString());
     }
 
     [Fact]

src/Tools/Source/CompilerGeneratorTools/Source/CSharpSyntaxGenerator/Model/TreeType.cs

@@ -26,9 +26,6 @@ public class TreeType
         [XmlElement]
         public Comment FactoryComment;
 
-        [XmlAttribute]
-        public string HasValidate;
-
         [XmlElement(ElementName = "Field", Type = typeof(Field))]
         [XmlElement(ElementName = "Choice", Type = typeof(Choice))]
         [XmlElement(ElementName = "Sequence", Type = typeof(Sequence))]

src/Tools/Source/CompilerGeneratorTools/Source/CSharpSyntaxGenerator/SourceWriter.cs

@@ -6,7 +6,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Threading;
@@ -847,12 +846,6 @@ private void WriteRedType(TreeType node)
                 WriteLine($"internal {node.Name}(InternalSyntax.CSharpSyntaxNode green, SyntaxNode? parent, int position)");
                 WriteLine("  : base(green, parent, position)");
                 OpenBlock();
-
-                if (HasValidate(node))
-                {
-                    WriteLine("Validate();");
-                }
-
                 CloseBlock();
                 WriteLine();
 
@@ -1026,11 +1019,6 @@ private void WriteRedType(TreeType node)
             }
         }
 
-        private bool HasValidate(TreeType node)
-        {
-            return node.HasValidate != null && string.Compare(node.HasValidate, "true", ignoreCase: true) == 0;
-        }
-
         private string GetRedFieldType(Field field)
         {
             if (field.Type == "SyntaxList<SyntaxToken>")
@@ -1118,18 +1106,7 @@ private void WriteRedUpdateMethod(Node node)
                     node.Fields.Select(f => CamelCase(f.Name))));
                 WriteLine(");");
                 WriteLine("var annotations = GetAnnotations();");
-
-                if (HasValidate(node))
-                {
-                    WriteLine("var result = annotations?.Length > 0 ? newNode.WithAnnotations(annotations) : newNode;");
-                    WriteLine("result.Validate();");
-                    WriteLine("return result;");
-                }
-                else
-                {
-                    WriteLine("return annotations?.Length > 0 ? newNode.WithAnnotations(annotations) : newNode;");
-                }
-
+                WriteLine("return annotations?.Length > 0 ? newNode.WithAnnotations(annotations) : newNode;");
                 CloseBlock();
             }