Skip to content

Commit aba5388

Browse files
committed
Fix required completion in records
1 parent afef833 commit aba5388

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/EditorFeatures/CSharpTest/Completion/CompletionProviders/KeywordCompletionProviderTests.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,9 @@ public async Task TestInCastExpressionThatMightBeParenthesizedExpression2(bool h
620620
[Theory]
621621
[InlineData("class")]
622622
[InlineData("struct")]
623-
public async Task SuggestRequiredInClassOrStruct(string type)
623+
[InlineData("record")]
624+
[InlineData("record struct")]
625+
public async Task SuggestRequiredInClassOrStructOrRecord(string type)
624626
{
625627
var markup = $$"""
626628
{{type}} C

src/Features/CSharp/Portable/Completion/KeywordRecommenders/RequiredKeywordRecommender.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@ internal class RequiredKeywordRecommender : AbstractSyntacticSingleKeywordRecomm
1515
{
1616
private static readonly ISet<SyntaxKind> s_validModifiers = SyntaxKindSet.AllMemberModifiers.Where(s => s is not (SyntaxKind.RequiredKeyword or SyntaxKind.StaticKeyword or SyntaxKind.ReadOnlyKeyword or SyntaxKind.ConstKeyword)).ToSet();
1717

18-
private static readonly ISet<SyntaxKind> s_validTypeDeclarations = new HashSet<SyntaxKind>(SyntaxFacts.EqualityComparer)
19-
{
20-
SyntaxKind.StructDeclaration,
21-
SyntaxKind.ClassDeclaration,
22-
};
18+
private static readonly ISet<SyntaxKind> s_validTypeDeclarations = SyntaxKindSet.ClassStructRecordTypeDeclarations;
2319

2420
public RequiredKeywordRecommender()
2521
: base(SyntaxKind.RequiredKeyword)

0 commit comments

Comments
 (0)