Merge pull request #62939 from Youssef1313/patch-31

Remove prefer system hash code from EditorConfig UI

Author: mavasani

src/VisualStudio/CSharp/Test/EditorConfigSettings/DataProvider/DataProviderTests.cs

@@ -112,12 +112,15 @@ public void TestGettingCodeStyleSettingProviderWorkspaceServiceAsync()
             var model = new TestViewModel();
             settingsProvider.RegisterViewModel(model);
             var dataSnapShot = settingsProvider.GetCurrentDataSnapshot();
-            // We need to substract as a UI for arbitrary strings for:
-            //
+
+            // We need to substract for string options that are not yet supported.
             // CodeStyleOptions2.OperatorPlacementWhenWrapping
             // CodeStyleOptions2.FileHeaderTemplate
+            // CodeStyleOptions2.RemoveUnnecessarySuppressionExclusions
+            //
+            // We also subtract for this not-yet supported option, tracked by https://github.com/dotnet/roslyn/issues/62937
             // CodeStyleOptions2.ForEachExplicitCastInSource
-            var optionsCount = CodeStyleOptions2.AllOptions.Where(x => x.StorageLocations.Any(y => y is IEditorConfigStorageLocation2)).Count() - 3;
+            var optionsCount = CodeStyleOptions2.AllOptions.Where(x => x.StorageLocations.Any(y => y is IEditorConfigStorageLocation2)).Count() - 4;
             Assert.Equal(optionsCount, dataSnapShot.Length);
         }
 

src/VisualStudio/Core/Def/EditorConfigSettings/DataProvider/CodeStyle/CommonCodeStyleSettingsProvider.cs

@@ -132,10 +132,6 @@ private IEnumerable<CodeStyleSetting> GetCodeBlockCodeStyleOptions(AnalyzerConfi
                 description: ServicesVSResources.analyzer_Prefer_auto_properties,
                 editorConfigOptions: options,
                 visualStudioOptions: visualStudioOptions, updater: updater, fileName: FileName);
-            yield return CodeStyleSetting.Create(option: CodeStyleOptions2.PreferSystemHashCode,
-                description: ServicesVSResources.Prefer_System_HashCode_in_GetHashCode,
-                editorConfigOptions: options,
-                visualStudioOptions: visualStudioOptions, updater: updater, fileName: FileName);
         }
 
         private IEnumerable<CodeStyleSetting> GetExpressionCodeStyleOptions(AnalyzerConfigOptions options, OptionSet visualStudioOptions, OptionUpdater updater)