Merge pull request #6803 from mavasani/UserDefinedConversion_CA1508

mavasani · web-flow · commit 62b7d16b95cb · 2023-07-26T14:58:51.000+05:30
Bail out from conversion inference for user-defined conversions
diff --git a/src/Utilities/FlowAnalysis/FlowAnalysis/Analysis/PointsToAnalysis/PointsToAnalysis.PointsToDataFlowOperationVisitor.cs b/src/Utilities/FlowAnalysis/FlowAnalysis/Analysis/PointsToAnalysis/PointsToAnalysis.PointsToDataFlowOperationVisitor.cs
@@ -1142,6 +1142,7 @@ public override PointsToAbstractValue VisitConversion(IConversionOperation opera
                 {
                     // Conservatively handle user defined conversions as escaping operations.
                     HandleEscapingOperation(operation, operation.Operand);
+                    return value;
                 }
 
                 ConversionInference? inference = null;

Original file line number	Diff line number	Diff line change
`@@ -1142,6 +1142,7 @@ public override PointsToAbstractValue VisitConversion(IConversionOperation opera`
`1142`	`1142`	`{`
`1143`	`1143`	`// Conservatively handle user defined conversions as escaping operations.`
`1144`	`1144`	`HandleEscapingOperation(operation, operation.Operand);`
	`1145`	`+ return value;`
`1145`	`1146`	`}`
`1146`	`1147`
`1147`	`1148`	`ConversionInference? inference = null;`