Merge remote-tracking branch 'upstream/main' into testClassification

Author: CyrusNajmabadi

azure-pipelines-official.yml

@@ -101,7 +101,7 @@ variables:
 
   - ${{ if and(notin(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.SourceBranch'], 'refs/heads/main')) }}:
     - name: enableSourceIndex
-      value: true
+      value: false
   - name: VSCodeOptimizationDataRoot
     value: $(Pipeline.Workspace)/profilingInputs/merged mibc
 

docs/compilers/CSharp/Compiler Breaking Changes - DotNet 10.md

@@ -364,3 +364,41 @@ class extension { } // type may not be named "extension"
 class C<extension> { } // type parameter may not be named "extension"
 ```
 
+## Partial properties and events are now implicitly virtual and public
+
+***Introduced in Visual Studio 2022 version 17.15***
+
+We have fixed [an inconsistency](https://github.com/dotnet/roslyn/issues/77346)
+where partial interface properties and events would not be implicitly `virtual` and `public` unlike their non-partial equivalents.
+This inconsistency is however [preserved](./Deviations%20from%20Standard.md#interface-partial-methods) for partial interface methods to avoid a larger breaking change.
+Note that Visual Basic and other languages not supporting default interface members will start requiring to implement implicitly virtual `partial` interface members.
+
+To keep the previous behavior, explicitly mark `partial` interface members as `private` (if they don't have any accessibility modifiers)
+and `sealed` (if they don't have the `private` modifier which implies `sealed`, and they don't already have modifier `virtual` or `sealed`).
+
+```cs
+System.Console.Write(((I)new C()).P); // wrote 1 previously, writes 2 now
+
+partial interface I
+{
+    public partial int P { get; }
+    public partial int P => 1; // implicitly virtual now
+}
+
+class C : I
+{
+    public int P => 2; // implements I.P
+}
+```
+
+```cs
+System.Console.Write(((I)new C()).P); // inaccessible previously, writes 1 now
+
+partial interface I
+{
+    partial int P { get; } // implicitly public now
+    partial int P => 1;
+}
+
+class C : I;
+```

docs/compilers/CSharp/Deviations from Standard.md

@@ -77,3 +77,10 @@ The compiler is free to make assumptions about the shape and behavior of well-kn
 It may not check for unexpected constraints, `Obsolete` attribute, or `UnmanagedCallersOnly` attribute.
 It may perform some optimizations based on expectations that the types/members are well-behaved.
 Note: the compiler should remain resilient to missing well-known types/members.
+
+# Interface partial methods
+
+Interface partial methods are implicitly non-virtual,
+unlike non-partial interface methods and other interface partial member kinds,
+see [a related breaking change](./Compiler%20Breaking%20Changes%20-%20DotNet%2010.md#partial-properties-and-events-are-now-implicitly-virtual-and-public)
+and [LDM 2025-04-07](https://github.com/dotnet/csharplang/blob/main/meetings/2025/LDM-2025-04-07.md#breaking-change-discussion-making-partial-members-in-interfaces-virtual-andor-public).

eng/Directory.Packages.props

@@ -145,7 +145,6 @@
     <PackageVersion Include="NuGet.ProjectModel" Version="6.8.0-rc.112" />
     <PackageVersion Include="Microsoft.TestPlatform.TranslationLayer" Version="$(MicrosoftNETTestSdkVersion)" />
     <PackageVersion Include="Microsoft.TestPlatform.ObjectModel" Version="$(MicrosoftNETTestSdkVersion)" />
-    <PackageVersion Include="Microsoft.AspNetCore.Razor.ExternalAccess.RoslynWorkspace" Version="9.0.0-preview.25064.4" />
 
     <!--
       Analyzers

eng/Publishing.props

@@ -1,13 +1,15 @@
-<?xml version="1.0" encoding="utf-8"?>
 <Project>
-   <PropertyGroup>
-      <PublishingVersion>3</PublishingVersion>
-   </PropertyGroup>
 
   <PropertyGroup>
     <PublishDependsOnTargets>_ResolvePublishRoslynNuGetPackages;$(PublishDependsOnTargets)</PublishDependsOnTargets>
   </PropertyGroup>
 
+  <!-- Update Artifacts with Kind=Package to have additional metadata item Category="ToolingPackage".
+       Depending on channel configuration, this means that these assets could be pushed to a different feed. -->
+  <ItemGroup>
+    <Artifact Update="@(Artifact->WithMetadataValue('Kind', 'Package'))" Category="ToolingPackage" />
+  </ItemGroup>
+
   <!--
     During PR Validation we only need to publish symbols with Arcade,
     since our packages are published separately to the CoreXT feed.
@@ -32,4 +34,5 @@
       <ItemsToPushToBlobFeed Include="@(_SymbolPackagesToPush)" />
     </ItemGroup>
   </Target>
-</Project>
+
+</Project>

eng/Version.Details.xml

@@ -13,9 +13,9 @@
       <SourceBuild RepoName="source-build-externals" ManagedOnly="true" />
     </Dependency>
     <!-- Intermediate is necessary for source build. -->
-    <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="10.0.621601">
+    <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="9.0.0-alpha.1.25223.3">
       <Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
-      <Sha>4b566314cf9602b77f25538a88b9c8175231c106</Sha>
+      <Sha>19eb5ea4e5f9c4e5256843a92805c8c9e942207d</Sha>
       <SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
     </Dependency>
     <Dependency Name="System.CommandLine" Version="2.0.0-beta5.25210.1">

src/Analyzers/Core/CodeFixes/Formatting/FormattingCodeFixProvider.cs

@@ -62,7 +62,7 @@ public sealed override Task RegisterCodeFixesAsync(CodeFixContext context)
     private async Task<Document> FixOneAsync(CodeFixContext context, Diagnostic diagnostic, CancellationToken cancellationToken)
     {
         var root = await context.Document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
-        var text = root.GetText();
+        var text = await context.Document.GetValueTextAsync(cancellationToken).ConfigureAwait(false);
 
         // The span to format is the full line(s) containing the diagnostic
         var diagnosticSpan = diagnostic.Location.SourceSpan;

src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs

@@ -1982,7 +1982,21 @@ private BoundCall CreateBadCall(
                 var constructedMethods = ArrayBuilder<MethodSymbol>.GetInstance();
                 foreach (var m in methods)
                 {
-                    constructedMethods.Add(m.ConstructedFrom == m && m.Arity == typeArgumentsWithAnnotations.Length ? m.Construct(typeArgumentsWithAnnotations) : m);
+                    MethodSymbol constructedMethod;
+                    if (m.GetIsNewExtensionMember())
+                    {
+                        constructedMethod = m.IsDefinition && m.GetMemberArityIncludingExtension() == typeArgumentsWithAnnotations.Length
+                            ? m.ConstructIncludingExtension(typeArgumentsWithAnnotations)
+                            : m;
+                    }
+                    else
+                    {
+                        constructedMethod = m.ConstructedFrom == m && m.Arity == typeArgumentsWithAnnotations.Length
+                            ? m.Construct(typeArgumentsWithAnnotations)
+                            : m;
+                    }
+
+                    constructedMethods.Add(constructedMethod);
                 }
 
                 methods = constructedMethods.ToImmutableAndFree();
@@ -2010,7 +2024,17 @@ private BoundCall CreateBadCall(
 
         private static bool IsUnboundGeneric(MethodSymbol method)
         {
-            return method.IsGenericMethod && method.ConstructedFrom == method;
+            if (method.GetMemberArityIncludingExtension() == 0)
+            {
+                return false;
+            }
+
+            if (!method.GetIsNewExtensionMember())
+            {
+                return method.ConstructedFrom == method;
+            }
+
+            return method.IsDefinition;
         }
 
         // Arbitrary limit on the number of parameter lists from overload
@@ -2023,9 +2047,9 @@ private ImmutableArray<BoundExpression> BuildArgumentsForErrorRecovery(AnalyzedA
             var parameterListList = ArrayBuilder<ImmutableArray<ParameterSymbol>>.GetInstance();
             foreach (var m in methods)
             {
-                if (!IsUnboundGeneric(m) && m.ParameterCount > 0)
+                if (!IsUnboundGeneric(m) && m.GetParameterCountIncludingExtensionParameter() > 0)
                 {
-                    parameterListList.Add(m.Parameters);
+                    parameterListList.Add(m.GetParametersIncludingExtensionParameter(skipExtensionIfStatic: false));
                     if (parameterListList.Count == MaxParameterListsForErrorRecovery)
                     {
                         break;
@@ -2043,6 +2067,7 @@ private ImmutableArray<BoundExpression> BuildArgumentsForErrorRecovery(AnalyzedA
             var parameterListList = ArrayBuilder<ImmutableArray<ParameterSymbol>>.GetInstance();
             foreach (var p in properties)
             {
+                // Tracked by https://github.com/dotnet/roslyn/issues/76130: Revisit this with new extensions
                 if (p.ParameterCount > 0)
                 {
                     parameterListList.Add(p.Parameters);

src/Compilers/CSharp/Portable/Binder/ExecutableCodeBinder.cs

@@ -107,9 +107,7 @@ public static void ValidateIteratorMethod(CSharpCompilation compilation, MethodS
                 return;
             }
 
-            var parameters = !iterator.IsStatic
-                ? iterator.GetParametersIncludingExtensionParameter()
-                : iterator.Parameters;
+            var parameters = iterator.GetParametersIncludingExtensionParameter(skipExtensionIfStatic: true);
 
             foreach (var parameter in parameters)
             {

src/Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/MethodTypeInference.cs

@@ -277,6 +277,7 @@ public static MethodTypeInferenceResult Infer(
                                                       // no arguments per se we cons up some fake arguments.
             ref CompoundUseSiteInfo<AssemblySymbol> useSiteInfo,
             Extensions extensions = null,
+            // Map of TypeParameterSymbol to ordinal for new extension methods
             Dictionary<TypeParameterSymbol, int> ordinals = null)
         {
             Debug.Assert(!methodTypeParameters.IsDefault);