Enable analyzer doc validation in correctness runs (#78420)

Resolves #78414

Author: dibarbet

eng/targets/GenerateAnalyzerNuspec.targets

@@ -37,8 +37,7 @@
       <_GeneratedRulesetsDir>$(IntermediateOutputPath)Rulesets</_GeneratedRulesetsDir>
       <_GeneratedEditorconfigsDir>$(IntermediateOutputPath)Editorconfig</_GeneratedEditorconfigsDir>
       <_GeneratedGlobalAnalyzerConfigsDir>$(IntermediateOutputPath)GlobalAnalyzerConfigs</_GeneratedGlobalAnalyzerConfigsDir>
-      <_ValidateOffline Condition="'$(DotNetBuildSourceOnly)' == 'true' or '$(DotNetBuild)' == 'true'">true</_ValidateOffline>
-      <_ValidateOffline Condition="'$(_ValidateOffline)' == ''">false</_ValidateOffline>
+      <ValidateAnalyzerDocsOffline Condition="'$(ValidateAnalyzerDocsOffline)' == ''">true</ValidateAnalyzerDocsOffline>
       <ContainsPortedFxCopRules Condition="'$(ContainsPortedFxCopRules)' == ''">false</ContainsPortedFxCopRules>
       <GeneratePackagePropsFile Condition="'$(GeneratePackagePropsFile)' == ''">true</GeneratePackagePropsFile>
       <GenerateDisableNETAnalyzersPackagePropsFile Condition=" '$(GenerateDisableNETAnalyzersPackagePropsFile)' == '' and '$(ContainsPortedFxCopRules)' == 'true'">true</GenerateDisableNETAnalyzersPackagePropsFile>
@@ -111,15 +110,11 @@
       <AnalyzerRulesetAssembly Update="@(AnalyzerRulesetAssembly)" Condition="'%(AnalyzerRulesetAssembly.TargetFramework)' == ''" TargetFramework="$(TargetFramework)" />
     </ItemGroup>
 
-    <PropertyGroup>
-      <SkipDocumentationValidation>true</SkipDocumentationValidation>
-    </PropertyGroup>
-
-    <!-- Only run validate only in CI builds. Running them in local builds will prevent refreshing auto-generated files. -->
-    <Exec Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(SkipDocumentationValidation)' != 'true'"
-          Command='"$(DotNetExecutable)" --roll-forward major "$(_GenerateDocumentationAndConfigFilesPath)" "-validateOnly:true" "$(_GeneratedRulesetsDir)" "$(_GeneratedEditorconfigsDir)" "$(_GeneratedGlobalAnalyzerConfigsDir)" "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" "$(Configuration)" "%(AnalyzerRulesetAssembly.TargetFramework)" "@(AnalyzerRulesetAssembly)" "$(PackagePropsFileDir)" "$(PackagePropsFileName)" "$(PackageTargetsFileDir)" "$(PackageTargetsFileName)" "$(DisableNETAnalyzersPackagePropsFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerDocumentationFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerSarifFileName)" "$(VersionPrefix)" $(NuspecPackageId) $(ContainsPortedFxCopRules) $(GenerateAnalyzerRulesMissingDocumentationFile) $(ReleaseTrackingOptOut) $(_ValidateOffline)' />
+    <!-- Only run validate only in CI correctness builds. Running them in local builds will prevent refreshing auto-generated files. -->
+    <Exec Condition="'$(ContinuousIntegrationBuildCorrectness)' == 'true'"
+          Command='"$(DotNetExecutable)" --roll-forward major "$(_GenerateDocumentationAndConfigFilesPath)" --validateOnly true --analyzerRulesetsDir "$(_GeneratedRulesetsDir)" --analyzerEditorconfigsDir "$(_GeneratedEditorconfigsDir)" --analyzerGlobalconfigsDir "$(_GeneratedGlobalAnalyzerConfigsDir)" --binDirectory "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" --configuration "$(Configuration)" --tfm "%(AnalyzerRulesetAssembly.TargetFramework)" --assemblies "@(AnalyzerRulesetAssembly)" --propsFileDir "$(PackagePropsFileDir)" --propsFileName "$(PackagePropsFileName)" --targetsFileDir "$(PackageTargetsFileDir)" --targetsFileName "$(PackageTargetsFileName)" --propsFileToDisableNetAnalyzers "$(DisableNETAnalyzersPackagePropsFileName)" --analyzerDocumentationFileDir "$(AnalyzerSarifFileDir)" --analyzerDocumentationFileName "$(AnalyzerDocumentationFileName)" --analyzerSarifFileDir "$(AnalyzerSarifFileDir)" --analyzerSarifFileName "$(AnalyzerSarifFileName)" --analyzerVersion "$(VersionPrefix)" --analyzerPackageName $(NuspecPackageId) --containsPortedFxcopRules $(ContainsPortedFxCopRules) --generateAnalyzerRulesMissingDocumentationFile $(GenerateAnalyzerRulesMissingDocumentationFile) --releaseTrackingOptOut $(ReleaseTrackingOptOut) --validateOffline $(ValidateAnalyzerDocsOffline)' />
 
-    <Exec Command='"$(DotNetExecutable)" --roll-forward major "$(_GenerateDocumentationAndConfigFilesPath)" "-validateOnly:false" "$(_GeneratedRulesetsDir)" "$(_GeneratedEditorconfigsDir)" "$(_GeneratedGlobalAnalyzerConfigsDir)" "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" "$(Configuration)" "%(AnalyzerRulesetAssembly.TargetFramework)" "@(AnalyzerRulesetAssembly)" "$(PackagePropsFileDir)" "$(PackagePropsFileName)" "$(PackageTargetsFileDir)" "$(PackageTargetsFileName)" "$(DisableNETAnalyzersPackagePropsFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerDocumentationFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerSarifFileName)" "$(VersionPrefix)" $(NuspecPackageId) $(ContainsPortedFxCopRules) $(GenerateAnalyzerRulesMissingDocumentationFile) $(ReleaseTrackingOptOut) $(_ValidateOffline)' />
+    <Exec Command='"$(DotNetExecutable)" --roll-forward major "$(_GenerateDocumentationAndConfigFilesPath)" --validateOnly false --analyzerRulesetsDir "$(_GeneratedRulesetsDir)" --analyzerEditorconfigsDir "$(_GeneratedEditorconfigsDir)" --analyzerGlobalconfigsDir "$(_GeneratedGlobalAnalyzerConfigsDir)" --binDirectory "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" --configuration "$(Configuration)" --tfm "%(AnalyzerRulesetAssembly.TargetFramework)" --assemblies "@(AnalyzerRulesetAssembly)" --propsFileDir "$(PackagePropsFileDir)" --propsFileName "$(PackagePropsFileName)" --targetsFileDir "$(PackageTargetsFileDir)" --targetsFileName "$(PackageTargetsFileName)" --propsFileToDisableNetAnalyzers "$(DisableNETAnalyzersPackagePropsFileName)" --analyzerDocumentationFileDir "$(AnalyzerSarifFileDir)" --analyzerDocumentationFileName "$(AnalyzerDocumentationFileName)" --analyzerSarifFileDir "$(AnalyzerSarifFileDir)" --analyzerSarifFileName "$(AnalyzerSarifFileName)" --analyzerVersion "$(VersionPrefix)" --analyzerPackageName $(NuspecPackageId) --containsPortedFxcopRules $(ContainsPortedFxCopRules) --generateAnalyzerRulesMissingDocumentationFile $(GenerateAnalyzerRulesMissingDocumentationFile) --releaseTrackingOptOut $(ReleaseTrackingOptOut) --validateOffline $(ValidateAnalyzerDocsOffline)' />
 
     <ItemGroup Condition="Exists('$(PackageTargetsFileDir)\$(PackageTargetsFileName)')">
       <AnalyzerNupkgFile Include="$(PackageTargetsFileDir)\$(PackageTargetsFileName)"/>

src/RoslynAnalyzers/Tools/GenerateDocumentationAndConfigFiles/GenerateDocumentationAndConfigFiles.csproj

@@ -27,5 +27,6 @@
     <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic" VersionOverride="$(MicrosoftCodeAnalysisVersion)" />
     <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" VersionOverride="$(MicrosoftCodeAnalysisVersion)" />
     <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" VersionOverride="$(MicrosoftCodeAnalysisVersion)" />
+    <PackageReference Include="System.CommandLine" />
   </ItemGroup>
 </Project>