Merge pull request #68014 from mavasani/SpanApiAnalyzers

mavasani · web-flow · commit 193c6598997a · 2023-05-01T14:03:31.000+05:30
Move the SyntaxTree and SemanticModel action based analyzers to respect context.FilterSpan
diff --git a/src/Analyzers/CSharp/Analyzers/AddAccessibilityModifiers/CSharpAddAccessibilityModifiersDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/AddAccessibilityModifiers/CSharpAddAccessibilityModifiersDiagnosticAnalyzer.cs
@@ -37,6 +37,9 @@ private void ProcessMemberDeclaration(
             SyntaxTreeAnalysisContext context,
             CodeStyleOption2<AccessibilityModifiersRequired> option, MemberDeclarationSyntax member)
         {
+            if (!context.ShouldAnalyzeSpan(member.Span))
+                return;
+
             if (member is BaseNamespaceDeclarationSyntax namespaceDeclaration)
                 ProcessMembers(context, option, namespaceDeclaration.Members);
 
diff --git a/src/Analyzers/CSharp/Analyzers/NewLines/ArrowExpressionClausePlacement/ArrowExpressionClausePlacementDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/NewLines/ArrowExpressionClausePlacement/ArrowExpressionClausePlacementDiagnosticAnalyzer.cs
@@ -36,7 +36,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)
             if (option.Value)
                 return;
 
-            Recurse(context, option.Notification.Severity, context.Tree.GetRoot(context.CancellationToken));
+            Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));
         }
 
         private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node)
@@ -48,6 +48,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.Span))
+                    continue;
+
                 if (child.IsNode)
                     Recurse(context, severity, child.AsNode()!);
             }
diff --git a/src/Analyzers/CSharp/Analyzers/NewLines/ConditionalExpressionPlacement/ConditionalExpressionPlacementDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/NewLines/ConditionalExpressionPlacement/ConditionalExpressionPlacementDiagnosticAnalyzer.cs
@@ -37,7 +37,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)
             if (option.Value)
                 return;
 
-            Recurse(context, option.Notification.Severity, context.Tree.GetRoot(context.CancellationToken));
+            Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));
         }
 
         private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node)
@@ -49,6 +49,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.Span))
+                    continue;
+
                 if (child.IsNode)
                     Recurse(context, severity, child.AsNode()!);
             }
diff --git a/src/Analyzers/CSharp/Analyzers/NewLines/ConsecutiveBracePlacement/ConsecutiveBracePlacementDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/NewLines/ConsecutiveBracePlacement/ConsecutiveBracePlacementDiagnosticAnalyzer.cs
@@ -46,7 +46,7 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit
             var tree = context.Tree;
             var cancellationToken = context.CancellationToken;
 
-            var root = tree.GetRoot(cancellationToken);
+            var root = context.GetAnalysisRoot(findInTrivia: false);
             var text = tree.GetText(cancellationToken);
 
             stack.Add(root);
@@ -63,6 +63,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit
 
                 foreach (var child in current.ChildNodesAndTokens())
                 {
+                    if (!context.ShouldAnalyzeSpan(child.FullSpan))
+                        continue;
+
                     if (child.IsNode)
                         stack.Add(child.AsNode()!);
                     else if (child.IsToken)
diff --git a/src/Analyzers/CSharp/Analyzers/NewLines/ConstructorInitializerPlacement/ConstructorInitializerPlacementDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/NewLines/ConstructorInitializerPlacement/ConstructorInitializerPlacementDiagnosticAnalyzer.cs
@@ -38,7 +38,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)
             if (option.Value)
                 return;
 
-            Recurse(context, option.Notification.Severity, context.Tree.GetRoot(context.CancellationToken));
+            Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));
         }
 
         private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node)
@@ -54,6 +54,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.Span))
+                    continue;
+
                 if (child.IsNode)
                     Recurse(context, severity, child.AsNode()!);
             }
diff --git a/src/Analyzers/CSharp/Analyzers/NewLines/EmbeddedStatementPlacement/EmbeddedStatementPlacementDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/NewLines/EmbeddedStatementPlacement/EmbeddedStatementPlacementDiagnosticAnalyzer.cs
@@ -37,7 +37,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)
             if (option.Value)
                 return;
 
-            Recurse(context, option.Notification.Severity, context.Tree.GetRoot(context.CancellationToken));
+            Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));
         }
 
         private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node)
@@ -59,6 +59,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.Span))
+                    continue;
+
                 if (child.IsNode)
                     Recurse(context, severity, child.AsNode()!);
             }
diff --git a/src/Analyzers/CSharp/Analyzers/OrderModifiers/CSharpOrderModifiersDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/OrderModifiers/CSharpOrderModifiersDiagnosticAnalyzer.cs
@@ -34,7 +34,7 @@ protected override void Recurse(
         {
             foreach (var child in root.ChildNodesAndTokens())
             {
-                if (child.IsNode)
+                if (child.IsNode && context.ShouldAnalyzeSpan(child.Span))
                 {
                     var node = child.AsNode();
                     if (node is MemberDeclarationSyntax memberDeclaration)
diff --git a/src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryNullableDirective/CSharpRemoveRedundantNullableDirectiveDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryNullableDirective/CSharpRemoveRedundantNullableDirectiveDiagnosticAnalyzer.cs
@@ -4,6 +4,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Text;
 using System.Threading;
 using Microsoft.CodeAnalysis.CodeStyle;
@@ -46,7 +47,12 @@ protected override void InitializeWorker(AnalysisContext context)
                 var defaultNullableContext = ((CSharpCompilation)context.Compilation).Options.NullableContextOptions;
                 context.RegisterSyntaxTreeAction(context =>
                 {
-                    var root = context.Tree.GetCompilationUnitRoot(context.CancellationToken);
+                    var root = context.GetAnalysisRoot(findInTrivia: true);
+
+                    // Bail out if the root contains no nullable directives.
+                    if (!root.ContainsDirective(SyntaxKind.NullableDirectiveTrivia))
+                        return;
+
                     var initialState = context.Tree.IsGeneratedCode(context.Options, CSharpSyntaxFacts.Instance, context.CancellationToken)
                         ? NullableContextOptions.Disable
                         : defaultNullableContext;
diff --git a/src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryNullableDirective/CSharpRemoveUnnecessaryNullableDirectiveDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryNullableDirective/CSharpRemoveUnnecessaryNullableDirectiveDiagnosticAnalyzer.cs
@@ -6,6 +6,7 @@
 using System.Collections.Concurrent;
 using System.Collections.Immutable;
 using System.Diagnostics.CodeAnalysis;
+using System.Linq;
 using System.Threading;
 using Microsoft.CodeAnalysis.CodeStyle;
 using Microsoft.CodeAnalysis.CSharp;
@@ -105,10 +106,10 @@ private ImmutableArray<Diagnostic> AnalyzeSemanticModel(SemanticModelAnalysisCon
 
             var compilationOptions = ((CSharpCompilationOptions)context.SemanticModel.Compilation.Options).NullableContextOptions;
 
-            DirectiveTriviaSyntax? previousRetainedDirective = null;
+            NullableDirectiveTriviaSyntax? previousRetainedDirective = null;
             NullableContextOptions? retainedOptions = compilationOptions;
 
-            DirectiveTriviaSyntax? currentOptionsDirective = null;
+            NullableDirectiveTriviaSyntax? currentOptionsDirective = null;
             var currentOptions = retainedOptions;
 
             for (var directive = root.GetFirstDirective(); directive is not null; directive = directive.GetNextDirective())
@@ -288,6 +289,12 @@ public void AnalyzeCodeBlock(CodeBlockAnalysisContext context)
 
             public void AnalyzeSemanticModel(SemanticModelAnalysisContext context)
             {
+                var root = context.GetAnalysisRoot(findInTrivia: true);
+
+                // Bail out if the root contains no nullable directives.
+                if (!root.ContainsDirective(SyntaxKind.NullableDirectiveTrivia))
+                    return;
+
                 // Get the state information for the syntax tree. If the state information is not available, it is
                 // initialized directly to a completed state, ensuring that concurrent (or future) calls to
                 // AnalyzeCodeBlock will always read completed==true, and intervalTree does not need to be initialized
diff --git a/src/Analyzers/CSharp/Analyzers/RemoveUnreachableCode/CSharpRemoveUnreachableCodeDiagnosticAnalyzer.cs b/src/Analyzers/CSharp/Analyzers/RemoveUnreachableCode/CSharpRemoveUnreachableCodeDiagnosticAnalyzer.cs
@@ -54,7 +54,7 @@ private void AnalyzeSemanticModel(SemanticModelAnalysisContext context)
             // binding diagnostics directly on the SourceMethodSymbol containing this block, and
             // so it can retrieve the diagnostics at practically no cost.
             var root = semanticModel.SyntaxTree.GetRoot(cancellationToken);
-            var diagnostics = semanticModel.GetDiagnostics(cancellationToken: cancellationToken);
+            var diagnostics = semanticModel.GetDiagnostics(context.FilterSpan, cancellationToken);
             foreach (var diagnostic in diagnostics)
             {
                 cancellationToken.ThrowIfCancellationRequested();
diff --git a/src/Analyzers/Core/Analyzers/FileHeaders/AbstractFileHeaderDiagnosticAnalyzer.cs b/src/Analyzers/Core/Analyzers/FileHeaders/AbstractFileHeaderDiagnosticAnalyzer.cs
@@ -56,6 +56,12 @@ private void HandleSyntaxTree(SyntaxTreeAnalysisContext context)
             }
 
             var fileHeader = FileHeaderHelper.ParseFileHeader(root);
+
+            if (!context.ShouldAnalyzeSpan(fileHeader.GetLocation(tree).SourceSpan))
+            {
+                return;
+            }
+
             if (fileHeader.IsMissing)
             {
                 context.ReportDiagnostic(Diagnostic.Create(s_missingHeaderDescriptor, fileHeader.GetLocation(tree)));
diff --git a/src/Analyzers/Core/Analyzers/NewLines/ConsecutiveStatementPlacement/AbstractConsecutiveStatementPlacementDiagnosticAnalyzer.cs b/src/Analyzers/Core/Analyzers/NewLines/ConsecutiveStatementPlacement/AbstractConsecutiveStatementPlacementDiagnosticAnalyzer.cs
@@ -42,10 +42,7 @@ private void AnalyzeSyntaxTree(SyntaxTreeAnalysisContext context)
             if (option.Value)
                 return;
 
-            var cancellationToken = context.CancellationToken;
-            var root = context.Tree.GetRoot(cancellationToken);
-
-            Recurse(context, option.Notification.Severity, root, cancellationToken);
+            Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false), context.CancellationToken);
         }
 
         private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node, CancellationToken cancellationToken)
@@ -58,6 +55,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.FullSpan))
+                    continue;
+
                 if (child.IsNode)
                     Recurse(context, severity, child.AsNode()!, cancellationToken);
             }
diff --git a/src/Analyzers/Core/Analyzers/NewLines/MultipleBlankLines/AbstractMultipleBlankLinesDiagnosticAnalyzer.cs b/src/Analyzers/Core/Analyzers/NewLines/MultipleBlankLines/AbstractMultipleBlankLinesDiagnosticAnalyzer.cs
@@ -38,10 +38,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)
             if (option.Value)
                 return;
 
-            var cancellationToken = context.CancellationToken;
-            var root = context.Tree.GetRoot(cancellationToken);
-
-            Recurse(context, option.Notification.Severity, root, cancellationToken);
+            Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false), context.CancellationToken);
         }
 
         private void Recurse(
@@ -58,6 +55,9 @@ private void Recurse(
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.FullSpan))
+                    continue;
+
                 if (child.IsNode)
                     Recurse(context, severity, child.AsNode()!, cancellationToken);
                 else if (child.IsToken)
diff --git a/src/Analyzers/Core/Analyzers/OrderModifiers/AbstractOrderModifiersDiagnosticAnalyzer.cs b/src/Analyzers/Core/Analyzers/OrderModifiers/AbstractOrderModifiersDiagnosticAnalyzer.cs
@@ -46,8 +46,7 @@ private void AnalyzeSyntaxTree(SyntaxTreeAnalysisContext context)
                 return;
             }
 
-            var root = context.Tree.GetRoot(context.CancellationToken);
-            Recurse(context, preferredOrder, option.Notification.Severity, root);
+            Recurse(context, preferredOrder, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));
         }
 
         protected abstract void Recurse(
diff --git a/src/Analyzers/Core/Analyzers/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs b/src/Analyzers/Core/Analyzers/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
@@ -80,7 +80,7 @@ private void AnalyzeSemanticModel(SemanticModelAnalysisContext context)
             var tree = context.SemanticModel.SyntaxTree;
             var cancellationToken = context.CancellationToken;
 
-            var unnecessaryImports = UnnecessaryImportsProvider.GetUnnecessaryImports(context.SemanticModel, cancellationToken);
+            var unnecessaryImports = UnnecessaryImportsProvider.GetUnnecessaryImports(context.SemanticModel, context.FilterSpan, cancellationToken);
             if (unnecessaryImports.Any())
             {
                 // The IUnnecessaryImportsService will return individual import pieces that
diff --git a/src/Analyzers/Core/Analyzers/SimplifyTypeNames/SimplifyTypeNamesDiagnosticAnalyzerBase.cs b/src/Analyzers/Core/Analyzers/SimplifyTypeNames/SimplifyTypeNamesDiagnosticAnalyzerBase.cs
@@ -108,7 +108,7 @@ private void AnalyzeCompilation(CompilationStartAnalysisContext context)
         /// <see cref="AnalyzeSemanticModel"/>.</returns>
         protected abstract bool IsIgnoredCodeBlock(SyntaxNode codeBlock);
         protected abstract ImmutableArray<Diagnostic> AnalyzeCodeBlock(CodeBlockAnalysisContext context);
-        protected abstract ImmutableArray<Diagnostic> AnalyzeSemanticModel(SemanticModelAnalysisContext context, SimpleIntervalTree<TextSpan, TextSpanIntervalIntrospector>? codeBlockIntervalTree);
+        protected abstract ImmutableArray<Diagnostic> AnalyzeSemanticModel(SemanticModelAnalysisContext context, SyntaxNode root, SimpleIntervalTree<TextSpan, TextSpanIntervalIntrospector>? codeBlockIntervalTree);
 
         public bool TrySimplify(SemanticModel model, SyntaxNode node, [NotNullWhen(true)] out Diagnostic? diagnostic, TSimplifierOptions options, CancellationToken cancellationToken)
         {
@@ -281,7 +281,7 @@ public void AnalyzeSemanticModel(SemanticModelAnalysisContext context)
                 //   true: the state was initialized on the previous line, and either intervalTree will be null, or
                 //         a previous call to AnalyzeSemanticModel was cancelled and the new one will operate on the
                 //         same interval tree presented during the previous call.
-                if (!completed.Value)
+                if (!completed.Value && !context.FilterSpan.HasValue)
                 {
                     // This lock ensures we do not use intervalTree while it is being updated by a concurrent call to
                     // AnalyzeCodeBlock.
@@ -292,7 +292,8 @@ public void AnalyzeSemanticModel(SemanticModelAnalysisContext context)
                     }
                 }
 
-                var diagnostics = _analyzer.AnalyzeSemanticModel(context, intervalTree);
+                var root = context.GetAnalysisRoot(findInTrivia: true);
+                var diagnostics = _analyzer.AnalyzeSemanticModel(context, root, intervalTree);
 
                 // After this point, cancellation is not allowed due to possible state alteration
                 foreach (var diagnostic in diagnostics)
diff --git a/src/Analyzers/VisualBasic/Analyzers/AddAccessibilityModifiers/VisualBasicAddAccessibilityModifiersDiagnosticAnalyzer.vb b/src/Analyzers/VisualBasic/Analyzers/AddAccessibilityModifiers/VisualBasicAddAccessibilityModifiersDiagnosticAnalyzer.vb
@@ -37,6 +37,10 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.AddAccessibilityModifiers
                 [option] As CodeStyleOption2(Of AccessibilityModifiersRequired),
                 member As StatementSyntax)
 
+            If Not context.ShouldAnalyzeSpan(member.Span) Then
+                Return
+            End If
+
             If member.Kind() = SyntaxKind.NamespaceBlock Then
                 Dim namespaceBlock = DirectCast(member, NamespaceBlockSyntax)
                 ProcessMembers(context, [option], namespaceBlock.Members)
diff --git a/src/Analyzers/VisualBasic/Analyzers/OrderModifiers/VisualBasicOrderModifiersDiagnosticAnalyzer.vb b/src/Analyzers/VisualBasic/Analyzers/OrderModifiers/VisualBasicOrderModifiersDiagnosticAnalyzer.vb
@@ -31,7 +31,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.OrderModifiers
             root As SyntaxNode)
 
             For Each child In root.ChildNodesAndTokens()
-                If child.IsNode Then
+                If child.IsNode And context.ShouldAnalyzeSpan(child.Span) Then
                     Dim declarationStatement = TryCast(child.AsNode(), DeclarationStatementSyntax)
                     If declarationStatement IsNot Nothing Then
                         If ShouldCheck(declarationStatement) Then
diff --git a/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.CompilationAnalyzer.cs b/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.CompilationAnalyzer.cs
@@ -32,7 +32,7 @@ public CompilationAnalyzer(Compilation compilation)
             public void AnalyzeSyntaxTree(SyntaxTreeAnalysisContext context)
             {
                 var semanticModel = _compilation.GetSemanticModel(context.Tree);
-                var diagnostics = semanticModel.GetSyntaxDiagnostics(cancellationToken: context.CancellationToken);
+                var diagnostics = semanticModel.GetSyntaxDiagnostics(context.FilterSpan, context.CancellationToken);
                 ReportDiagnostics(diagnostics, context.ReportDiagnostic, IsSourceLocation, s_syntactic);
             }
 
diff --git a/src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpSimplifyTypeNamesDiagnosticAnalyzer.cs b/src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpSimplifyTypeNamesDiagnosticAnalyzer.cs
@@ -58,15 +58,10 @@ protected override ImmutableArray<Diagnostic> AnalyzeCodeBlock(CodeBlockAnalysis
             return simplifier.Diagnostics;
         }
 
-        protected override ImmutableArray<Diagnostic> AnalyzeSemanticModel(SemanticModelAnalysisContext context, SimpleIntervalTree<TextSpan, TextSpanIntervalIntrospector>? codeBlockIntervalTree)
+        protected override ImmutableArray<Diagnostic> AnalyzeSemanticModel(SemanticModelAnalysisContext context, SyntaxNode root, SimpleIntervalTree<TextSpan, TextSpanIntervalIntrospector>? codeBlockIntervalTree)
         {
-            var semanticModel = context.SemanticModel;
-            var cancellationToken = context.CancellationToken;
-
             var options = context.GetCSharpAnalyzerOptions().GetSimplifierOptions();
-            var root = semanticModel.SyntaxTree.GetRoot(cancellationToken);
-
-            var simplifier = new TypeSyntaxSimplifierWalker(this, semanticModel, options, ignoredSpans: codeBlockIntervalTree, cancellationToken);
+            var simplifier = new TypeSyntaxSimplifierWalker(this, context.SemanticModel, options, ignoredSpans: codeBlockIntervalTree, context.CancellationToken);
             simplifier.Visit(root);
             return simplifier.Diagnostics;
         }
diff --git a/src/Features/Core/Portable/EmbeddedLanguages/Json/LanguageServices/AbstractJsonDetectionAnalyzer.cs b/src/Features/Core/Portable/EmbeddedLanguages/Json/LanguageServices/AbstractJsonDetectionAnalyzer.cs
@@ -46,16 +46,11 @@ protected override void InitializeWorker(AnalysisContext context)
 
         public void Analyze(SemanticModelAnalysisContext context)
         {
-            var semanticModel = context.SemanticModel;
-            var syntaxTree = semanticModel.SyntaxTree;
-            var cancellationToken = context.CancellationToken;
-
             if (!context.GetIdeAnalyzerOptions().DetectAndOfferEditorFeaturesForProbableJsonStrings)
                 return;
 
-            var detector = JsonLanguageDetector.GetOrCreate(semanticModel.Compilation, _info);
-            var root = syntaxTree.GetRoot(cancellationToken);
-            Analyze(context, detector, root, cancellationToken);
+            var detector = JsonLanguageDetector.GetOrCreate(context.SemanticModel.Compilation, _info);
+            Analyze(context, detector, context.GetAnalysisRoot(findInTrivia: true), context.CancellationToken);
         }
 
         private void Analyze(
@@ -68,6 +63,9 @@ private void Analyze(
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.FullSpan))
+                    continue;
+
                 if (child.IsNode)
                 {
                     Analyze(context, detector, child.AsNode()!, cancellationToken);
diff --git a/src/Features/Core/Portable/EmbeddedLanguages/Json/LanguageServices/AbstractJsonDiagnosticAnalyzer.cs b/src/Features/Core/Portable/EmbeddedLanguages/Json/LanguageServices/AbstractJsonDiagnosticAnalyzer.cs
@@ -40,17 +40,11 @@ protected override void InitializeWorker(AnalysisContext context)
 
         public void Analyze(SemanticModelAnalysisContext context)
         {
-            var semanticModel = context.SemanticModel;
-            var syntaxTree = semanticModel.SyntaxTree;
-            var cancellationToken = context.CancellationToken;
-
-            var option = context.GetIdeAnalyzerOptions().ReportInvalidJsonPatterns;
-            if (!option)
+            if (!context.GetIdeAnalyzerOptions().ReportInvalidJsonPatterns)
                 return;
 
-            var detector = JsonLanguageDetector.GetOrCreate(semanticModel.Compilation, _info);
-            var root = syntaxTree.GetRoot(cancellationToken);
-            Analyze(context, detector, root, cancellationToken);
+            var detector = JsonLanguageDetector.GetOrCreate(context.SemanticModel.Compilation, _info);
+            Analyze(context, detector, context.GetAnalysisRoot(findInTrivia: true), context.CancellationToken);
         }
 
         private void Analyze(
@@ -63,6 +57,9 @@ private void Analyze(
 
             foreach (var child in node.ChildNodesAndTokens())
             {
+                if (!context.ShouldAnalyzeSpan(child.FullSpan))
+                    continue;
+
                 if (child.IsNode)
                 {
                     Analyze(context, detector, child.AsNode()!, cancellationToken);
diff --git a/src/Features/Core/Portable/EmbeddedLanguages/RegularExpressions/LanguageServices/AbstractRegexDiagnosticAnalyzer.cs b/src/Features/Core/Portable/EmbeddedLanguages/RegularExpressions/LanguageServices/AbstractRegexDiagnosticAnalyzer.cs
diff --git a/src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicSimplifyTypeNamesDiagnosticAnalyzer.vb b/src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicSimplifyTypeNamesDiagnosticAnalyzer.vb
diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CompilerExtensions.projitems b/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CompilerExtensions.projitems
diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/AnalysisContextExtensions.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/AnalysisContextExtensions.cs
diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/SyntaxTreeExtensions.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/SyntaxTreeExtensions.cs
diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Helpers/RemoveUnnecessaryImports/AbstractUnnecessaryImportsProvider.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Helpers/RemoveUnnecessaryImports/AbstractUnnecessaryImportsProvider.cs
diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Helpers/RemoveUnnecessaryImports/IUnnecessaryImportsProvider.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Helpers/RemoveUnnecessaryImports/IUnnecessaryImportsProvider.cs
diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/LanguageServices/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsService.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/LanguageServices/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsService.cs

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@ private void ProcessMemberDeclaration(`
`37`	`37`	`SyntaxTreeAnalysisContext context,`
`38`	`38`	`CodeStyleOption2<AccessibilityModifiersRequired> option, MemberDeclarationSyntax member)`
`39`	`39`	`{`
	`40`	`+ if (!context.ShouldAnalyzeSpan(member.Span))`
	`41`	`+ return;`
	`42`	`+`
`40`	`43`	`if (member is BaseNamespaceDeclarationSyntax namespaceDeclaration)`
`41`	`44`	`ProcessMembers(context, option, namespaceDeclaration.Members);`
`42`	`45`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)`
`36`	`36`	`if (option.Value)`
`37`	`37`	`return;`
`38`	`38`
`39`		`- Recurse(context, option.Notification.Severity, context.Tree.GetRoot(context.CancellationToken));`
	`39`	`+ Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node)`
`@@ -48,6 +48,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit`
`48`	`48`
`49`	`49`	`foreach (var child in node.ChildNodesAndTokens())`
`50`	`50`	`{`
	`51`	`+ if (!context.ShouldAnalyzeSpan(child.Span))`
	`52`	`+ continue;`
	`53`	`+`
`51`	`54`	`if (child.IsNode)`
`52`	`55`	`Recurse(context, severity, child.AsNode()!);`
`53`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)`
`37`	`37`	`if (option.Value)`
`38`	`38`	`return;`
`39`	`39`
`40`		`- Recurse(context, option.Notification.Severity, context.Tree.GetRoot(context.CancellationToken));`
	`40`	`+ Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node)`
`@@ -49,6 +49,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit`
`49`	`49`
`50`	`50`	`foreach (var child in node.ChildNodesAndTokens())`
`51`	`51`	`{`
	`52`	`+ if (!context.ShouldAnalyzeSpan(child.Span))`
	`53`	`+ continue;`
	`54`	`+`
`52`	`55`	`if (child.IsNode)`
`53`	`56`	`Recurse(context, severity, child.AsNode()!);`
`54`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ private void AnalyzeTree(SyntaxTreeAnalysisContext context)`
`38`	`38`	`if (option.Value)`
`39`	`39`	`return;`
`40`	`40`
`41`		`- Recurse(context, option.Notification.Severity, context.Tree.GetRoot(context.CancellationToken));`
	`41`	`+ Recurse(context, option.Notification.Severity, context.GetAnalysisRoot(findInTrivia: false));`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severity, SyntaxNode node)`
`@@ -54,6 +54,9 @@ private void Recurse(SyntaxTreeAnalysisContext context, ReportDiagnostic severit`
`54`	`54`
`55`	`55`	`foreach (var child in node.ChildNodesAndTokens())`
`56`	`56`	`{`
	`57`	`+ if (!context.ShouldAnalyzeSpan(child.Span))`
	`58`	`+ continue;`
	`59`	`+`
`57`	`60`	`if (child.IsNode)`
`58`	`61`	`Recurse(context, severity, child.AsNode()!);`
`59`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ protected override void Recurse(`
`34`	`34`	`{`
`35`	`35`	`foreach (var child in root.ChildNodesAndTokens())`
`36`	`36`	`{`
`37`		`- if (child.IsNode)`
	`37`	`+ if (child.IsNode && context.ShouldAnalyzeSpan(child.Span))`
`38`	`38`	`{`
`39`	`39`	`var node = child.AsNode();`
`40`	`40`	`if (node is MemberDeclarationSyntax memberDeclaration)`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ private void AnalyzeSemanticModel(SemanticModelAnalysisContext context)`
`54`	`54`	`// binding diagnostics directly on the SourceMethodSymbol containing this block, and`
`55`	`55`	`// so it can retrieve the diagnostics at practically no cost.`
`56`	`56`	`var root = semanticModel.SyntaxTree.GetRoot(cancellationToken);`
`57`		`- var diagnostics = semanticModel.GetDiagnostics(cancellationToken: cancellationToken);`
	`57`	`+ var diagnostics = semanticModel.GetDiagnostics(context.FilterSpan, cancellationToken);`
`58`	`58`	`foreach (var diagnostic in diagnostics)`
`59`	`59`	`{`
`60`	`60`	`cancellationToken.ThrowIfCancellationRequested();`