Fix some issues with our options in the new experience #12262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to release/dev18.0 |
Contributor
|
Started backporting to release/dev18.0: https://github.com/dotnet/razor/actions/runs/17965605312 |
2 tasks
DustinCampbell
approved these changes
Sep 24, 2025
davidwengier
added a commit
that referenced
this pull request
Sep 25, 2025
…nce (#12263) Backport of #12262 to release/dev18.0 /cc @davidwengier ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
chsienki
added a commit
that referenced
this pull request
Oct 3, 2025
Reverts #12262 Reverting this while we understand if it's the cause of the fault issues in RPS.
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12260
Fixes #10200
First commit fixes a stupid bug I introduced which caused our settings to just not work. Sometimes it seems they would migrate from the legacy settings, but it was pretty hit and miss.
In manual testing, I then ran into #10200 which I'd forgotten that I'd logged a while ago, but with the benefit of time now that the old options screen is gone completely, the fix is really easy. Seems the legacy settings were just delayed as compared to UI events in the unified settings experience, but we can now just read directly from unified settings. Then I cleaned up a bit.