Add codelens endpoints and services for cohosting #12078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # eng/Version.Details.props # eng/Version.Details.xml # eng/targets/Services.props
davidwengier
commented
Aug 7, 2025
| VSInternalCompletionList? completionList = null; | ||
| using (_telemetryReporter.TrackLspRequest(Methods.TextDocumentCompletionName, Constants.ExternalAccessServerName, TelemetryThresholds.CompletionSubLSPTelemetryThreshold, correlationId)) | ||
| { | ||
| #pragma warning disable CS0618 // Type or member is obsolete. Will be addressed in a future PR but Roslyn changes are batched |
There was a problem hiding this comment.
This, and all of the other suppressions added in this PR, are removed in #12079
chsienki
approved these changes
Aug 18, 2025
This was referenced Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12047
Fixes #11818
Fixes dotnet/vscode-csharp#8482
Needs dotnet/roslyn#79795 inserted and referenced to build etc.
Bug: microsoft/vscode-dotnettools#2235