PR feedback

Author: ryanbrandenburg

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorDocumentSynchronizationEndpoint.cs

@@ -80,9 +80,9 @@ public async Task<Unit> Handle(DidChangeTextDocumentParams notification, Cancell
             var sourceText = await document.GetTextAsync();
             sourceText = ApplyContentChanges(notification.ContentChanges, sourceText);
 
-            if(notification.TextDocument.Version is null)
+            if (notification.TextDocument.Version is null)
             {
-                throw new NotImplementedException("Provided version should not be null.");
+                throw new InvalidOperationException("Provided version should not be null.");
             }
 
             await Task.Factory.StartNew(
@@ -102,7 +102,7 @@ public async Task<Unit> Handle(DidOpenTextDocumentParams notification, Cancellat
 
             if (notification.TextDocument.Version is null)
             {
-                throw new NotImplementedException("Provided version should not be null.");
+                throw new InvalidOperationException("Provided version should not be null.");
             }
 
             await Task.Factory.StartNew(

src/Razor/src/Microsoft.VisualStudio.LanguageServer.ContainedLanguage/DefaultLSPDocument.cs

@@ -57,7 +57,7 @@ public override LSPDocumentSnapshot CurrentSnapshot
             }
         }
 
-        [Obsolete]
+        [Obsolete("Use the int overload instead")]
         public override LSPDocumentSnapshot UpdateVirtualDocument<TVirtualDocument>(IReadOnlyList<ITextChange> changes, long hostDocumentVersion)
         {
             return UpdateVirtualDocument<TVirtualDocument>(changes, (int)hostDocumentVersion);

src/Razor/src/Microsoft.VisualStudio.LanguageServer.ContainedLanguage/LSPDocument.cs

@@ -19,7 +19,7 @@ public abstract class LSPDocument : IDisposable
 
         public abstract IReadOnlyList<VirtualDocument> VirtualDocuments { get; }
 
-        [Obsolete]
+        [Obsolete("Use the int overload instead")]
         public abstract LSPDocumentSnapshot UpdateVirtualDocument<TVirtualDocument>(IReadOnlyList<ITextChange> changes, long hostDocumentVersion) where TVirtualDocument : VirtualDocument;
 
         public abstract LSPDocumentSnapshot UpdateVirtualDocument<TVirtualDocument>(IReadOnlyList<ITextChange> changes, int hostDocumentVersion) where TVirtualDocument : VirtualDocument;