Skip to content

Commit 06b9bd1

Browse files
committed
Move to central package pinning
This should make it much easier for us to respond to CG alerts in the future. All that will need to be done is add an entry in Directory.Packages.props and it will automatically impact all consumers of it. Consider this example in Roslyn for how to respond to a CG issue dotnet/roslyn#74653
1 parent 36542b2 commit 06b9bd1

File tree

6 files changed

+16
-6
lines changed

6 files changed

+16
-6
lines changed

Directory.Build.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<RepositoryRoot>$(MSBuildThisFileDirectory)</RepositoryRoot>
2727
<EnableWindowsTargeting Condition="'$(DotNetBuildFromSource)' != 'true'">true</EnableWindowsTargeting>
2828
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
29+
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
2930

3031
<SharedSourceRoot>$(MSBuildThisFileDirectory)src\Shared\</SharedSourceRoot>
3132

Directory.Packages.props

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<_MicrosoftCodeAnalysisAnalyzersPackageVersion>3.11.0-beta1.24170.2</_MicrosoftCodeAnalysisAnalyzersPackageVersion>
1717
<_MicrosoftVisualStudioLanguageServicesPackageVersion>$(MicrosoftVisualStudioLanguageServicesPackageVersion)</_MicrosoftVisualStudioLanguageServicesPackageVersion>
1818
<_XunitPackageVersion>2.6.3</_XunitPackageVersion>
19-
<_MicrosoftBuildPackageVersion>17.3.0-preview-22364-05</_MicrosoftBuildPackageVersion>
19+
<_MicrosoftBuildPackageVersion>17.11.0-preview-24309-01</_MicrosoftBuildPackageVersion>
2020
</PropertyGroup>
2121

2222
<ItemGroup>
@@ -89,7 +89,7 @@
8989
<PackageVersion Include="Microsoft.VisualStudio.RpcContracts" Version="17.11.8" />
9090
<PackageVersion Include="Microsoft.VisualStudio.Shell.Framework" Version="$(_MicrosoftVisualStudioShellPackagesVersion)" />
9191
<PackageVersion Include="Microsoft.VisualStudio.Shell.15.0" Version="$(_MicrosoftVisualStudioShellPackagesVersion)" />
92-
<PackageVersion Include="Microsoft.VisualStudio.Telemetry" Version="17.9.102" />
92+
<PackageVersion Include="Microsoft.VisualStudio.Telemetry" Version="17.11.8" />
9393
<PackageVersion Include="Microsoft.VisualStudio.Text.Data" Version="$(_MicrosoftVisualStudioPackagesVersion)" />
9494
<PackageVersion Include="Microsoft.VisualStudio.Text.Implementation" Version="$(_MicrosoftVisualStudioPackagesVersion)" NoWarn="NU1701" />
9595
<PackageVersion Include="Microsoft.VisualStudio.Text.Logic" Version="$(_MicrosoftVisualStudioPackagesVersion)" />
@@ -110,12 +110,12 @@
110110
<PackageVersion Include="Roslyn.Diagnostics.Analyzers" Version="$(_MicrosoftCodeAnalysisAnalyzersPackageVersion)" />
111111
<PackageVersion Include="System.Collections.Immutable" Version="$(SystemCollectionsImmutablePackageVersion)" />
112112
<PackageVersion Include="System.Resources.Extensions" Version="6.0.0" />
113-
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
113+
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="8.0.0" />
114114
<PackageVersion Include="System.Private.Uri" Version="4.3.2" />
115115
<PackageVersion Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataPackageVersion)" />
116116
<PackageVersion Include="System.Security.Cryptography.Xml" Version="6.0.1" />
117117
<PackageVersion Include="System.Text.Encodings.Web" Version="8.0.0" />
118-
<PackageVersion Include="System.Text.Json" Version="6.0.0" />
118+
<PackageVersion Include="System.Text.Json" Version="8.0.4" />
119119
<PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
120120
<PackageVersion Include="xunit" Version="$(_XunitPackageVersion)" />
121121
<PackageVersion Include="Xunit.Combinatorial" Version="1.5.25" />

src/Compiler/Microsoft.AspNetCore.Razor.Language/legacyTest/Microsoft.AspNetCore.Razor.Language.Legacy.Test.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121

2222
<PackageReference Include="Newtonsoft.Json" />
2323
<PackageReference Include="Moq" />
24+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
25+
<PackageReference Include="Microsoft.CodeAnalysis.Common" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
26+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
2427
</ItemGroup>
2528

2629
<ItemGroup>

src/Compiler/Microsoft.AspNetCore.Razor.Language/test/Microsoft.AspNetCore.Razor.Language.Test.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121

2222
<PackageReference Include="Newtonsoft.Json" />
2323
<PackageReference Include="Moq" />
24+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
25+
<PackageReference Include="Microsoft.CodeAnalysis.Common" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
26+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
2427
</ItemGroup>
2528

2629
<ItemGroup>

src/Compiler/perf/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator/Microsoft.AspNetCore.Razor.Microbenchmarks.Generator.csproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@
2121
<ItemGroup>
2222
<PackageReference Include="BenchmarkDotNet" />
2323
<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" />
24-
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" />
25-
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" />
24+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
25+
<PackageReference Include="Microsoft.CodeAnalysis.Common" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
26+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
2627
<PackageReference Include="Microsoft.Build.Locator" />
2728
<PackageReference Include="System.Security.Cryptography.Xml" />
2829
</ItemGroup>

src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/Microsoft.NET.Sdk.Razor.SourceGenerators.Test.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
<PackageReference Include="Microsoft.Build.Framework" />
2626
<PackageReference Include="Microsoft.Build.Utilities.Core" />
2727
<PackageReference Include="Moq" />
28+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
29+
<PackageReference Include="Microsoft.CodeAnalysis.Common" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
2830
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" VersionOverride="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
2931
<PackageReference Include="xunit.extensibility.execution" />
3032
</ItemGroup>

0 commit comments

Comments
 (0)