Skip to content

Avoid duplicating My in settings type if no root namespace exists #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Avoid duplicating My in settings type if no root namespace exists #8888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37b6572
Avoid duplicating My in settings type if no root namespace exists
adamint Mar 2, 2023
0cd3ba3
update check to AndAlso
adamint Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.VisualStudio.Editors/SettingsDesigner/SettingsSingleFileGeneratorBase.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ Namespace Microsoft.VisualStudio.Editors.SettingsDesigner
fullTypeName = projectRootNamespace & "."
End If

If defaultNamespace <> "" Then
If defaultNamespace <> "" AndAlso Not defaultNamespace.Equals(MyNamespaceName) Then ' defaultNamespace, if none exists, will come in thru wszDefaultNamespace as My. We don't want to duplicate it.
fullTypeName &= defaultNamespace & "."
End If

Expand Down