Avoid duplicating My in settings type if no root namespace exists

[adamint]

Fixes AB#1741242

If the user has not defined a default namespace in VB .net framework, it will default to "My". We want to avoid My.My. being generated in the file generator.

Microsoft Reviewers: Open in CodeFlow

[MiYanni]

I took a look at the blame for this. Looks like you added the if-statement above this one for projectRootNamespace. So, is My being duplicated because your new if-statement prior to this has projectRootNamespace set to My? Then this if-statement was also executing causing My.My for fullTypeName?

[adamint]

Correct.

[adamint]

Relevant snippet:

There was a line that checks whether default namespace is empty, and if so does not append it to the generated type. So my assumption when modifying the file was that meant that having no default namespace would mean that the default namespace passed into the generator would be “”

[drewnoakes]

Summoning a Ballad by Paul Vick:

Suggested change

	If defaultNamespace <> "" And Not defaultNamespace.Equals(MyNamespaceName) Then ' defaultNamespace, if none exists, will come in thru wszDefaultNamespace as My. We don't want to duplicate it.
	If defaultNamespace <> "" AndAlso Not defaultNamespace.Equals(MyNamespaceName) Then ' defaultNamespace, if none exists, will come in thru wszDefaultNamespace as My. We don't want to duplicate it.

[adamint]

Interesting. Will add

[drewnoakes]

Is there a bug we can link this to, or repro steps to get into the state you are trying to prevent? The fix seems fine, but it's a bit abstract without that extra detail.

[adamint]

@drewnoakes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1741242/