Remove potentially redundant UI switch

drewnoakes · drewnoakes · commit 3e8ae2fbcad7 · 2022-09-29T13:56:17.000+10:00
If `IVsShellServices` has already been initialised, we won't need the UI thread. Avoid the switch before calling it.
diff --git a/src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/LanguageServices/LanguageServiceHostEnvironment.cs b/src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/LanguageServices/LanguageServiceHostEnvironment.cs
@@ -19,8 +19,6 @@ public LanguageServiceHostEnvironment(IVsShellServices vsShell, JoinableTaskCont
         _isEnabled = new(
             async () =>
             {
-                await joinableTaskContext.Factory.SwitchToMainThreadAsync();
-
                 // If VS is running in command line mode (e.g. "devenv.exe /build my.sln"),
                 // the language service host is not enabled. The one exception to this is
                 // when we're populating a solution cache via "/populateSolutionCache".

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,6 @@ public LanguageServiceHostEnvironment(IVsShellServices vsShell, JoinableTaskCont`
`19`	`19`	`_isEnabled = new(`
`20`	`20`	`async () =>`
`21`	`21`	`{`
`22`		`- await joinableTaskContext.Factory.SwitchToMainThreadAsync();`
`23`		`-`
`24`	`22`	`// If VS is running in command line mode (e.g. "devenv.exe /build my.sln"),`
`25`	`23`	`// the language service host is not enabled. The one exception to this is`
`26`	`24`	`// when we're populating a solution cache via "/populateSolutionCache".`