Fix marshaling of LOADED_IMAGE

Fixes #398

Author: AArnott

src/DbgHelp/DbgHelp+LOADED_IMAGE.cs

@@ -4,8 +4,13 @@
 namespace PInvoke
 {
     using System;
+    using System.Diagnostics;
     using System.Runtime.InteropServices;
 
+#pragma warning disable SA1623 // Property summary documentation must match accessors
+#pragma warning disable SA1300 // Element must begin with upper-case letter
+#pragma warning disable SA1202 // Elements must be ordered by access
+
     /// <content>
     /// Contains the <see cref="LOADED_IMAGE"/> nested type.
     /// </content>
@@ -59,24 +64,14 @@ public unsafe partial struct LOADED_IMAGE
             /// </summary>
             public Characteristics Characteristics;
 
-            /// <summary>
-            /// If the image is a kernel mode executable image, this value is TRUE.
-            /// </summary>
-            [MarshalAs(UnmanagedType.Bool)]
-            public bool fSystemImage;
+            [DebuggerBrowsable(DebuggerBrowsableState.Never)]
+            private byte fSystemImageByte;
 
-            /// <summary>
-            /// If the image is a 16-bit executable image, this value is TRUE.
-            /// </summary>
-            [MarshalAs(UnmanagedType.Bool)]
-            public bool fDOSImage;
+            [DebuggerBrowsable(DebuggerBrowsableState.Never)]
+            private byte fDOSImageByte;
 
-            /// <summary>
-            /// If the image is read-only, this value is TRUE.
-            /// Prior to Windows Vista:  This member is not included in the structure.
-            /// </summary>
-            [MarshalAs(UnmanagedType.Bool)]
-            public bool fReadOnly;
+            [DebuggerBrowsable(DebuggerBrowsableState.Never)]
+            private byte fReadOnlyByte;
 
             /// <summary>
             /// The version string.
@@ -92,7 +87,35 @@ public unsafe partial struct LOADED_IMAGE
             /// <summary>
             /// The size of the image, in bytes.
             /// </summary>
-            public int SizeOfImage;
+            public uint SizeOfImage;
+
+            /// <summary>
+            /// If the image is a kernel mode executable image, this value is TRUE.
+            /// </summary>
+            public bool fSystemImage
+            {
+                get => this.fSystemImageByte != 0;
+                set => this.fSystemImageByte = value ? (byte)1 : (byte)0;
+            }
+
+            /// <summary>
+            /// If the image is a 16-bit executable image, this value is TRUE.
+            /// </summary>
+            public bool fDOSImage
+            {
+                get => this.fDOSImageByte != 0;
+                set => this.fDOSImageByte = value ? (byte)1 : (byte)0;
+            }
+
+            /// <summary>
+            /// If the image is read-only, this value is TRUE.
+            /// Prior to Windows Vista:  This member is not included in the structure.
+            /// </summary>
+            public bool fReadOnly
+            {
+                get => this.fReadOnlyByte != 0;
+                set => this.fReadOnlyByte = value ? (byte)1 : (byte)0;
+            }
         }
     }
 }

src/DbgHelp/PublicAPI.Shipped.txt

@@ -18,9 +18,6 @@ PInvoke.DbgHelp.LOADED_IMAGE.NumberOfSections -> int
 PInvoke.DbgHelp.LOADED_IMAGE.Sections -> PInvoke.IMAGE_SECTION_HEADER*
 PInvoke.DbgHelp.LOADED_IMAGE.Sections_IntPtr.get -> System.IntPtr
 PInvoke.DbgHelp.LOADED_IMAGE.Sections_IntPtr.set -> void
-PInvoke.DbgHelp.LOADED_IMAGE.SizeOfImage -> int
+PInvoke.DbgHelp.LOADED_IMAGE.SizeOfImage -> uint
 PInvoke.DbgHelp.LOADED_IMAGE.Version -> byte
-PInvoke.DbgHelp.LOADED_IMAGE.fDOSImage -> bool
-PInvoke.DbgHelp.LOADED_IMAGE.fReadOnly -> bool
-PInvoke.DbgHelp.LOADED_IMAGE.fSystemImage -> bool
 PInvoke.DbgHelp.LOADED_IMAGE.hFile -> System.IntPtr

src/DbgHelp/PublicAPI.Unshipped.txt

@@ -0,0 +1,6 @@
+PInvoke.DbgHelp.LOADED_IMAGE.fDOSImage.get -> bool
+PInvoke.DbgHelp.LOADED_IMAGE.fDOSImage.set -> void
+PInvoke.DbgHelp.LOADED_IMAGE.fReadOnly.get -> bool
+PInvoke.DbgHelp.LOADED_IMAGE.fReadOnly.set -> void
+PInvoke.DbgHelp.LOADED_IMAGE.fSystemImage.get -> bool
+PInvoke.DbgHelp.LOADED_IMAGE.fSystemImage.set -> void