Make TraceCollector work on Linux #4706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentBu
commented
Feb 12, 2025
...gc/GC.Infrastructure/GC.Infrastructure.Core/CommandBuilders/Microbenchmark.CommandBuilder.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Feb 19, 2025
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/TraceCollection/TraceCollector.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Feb 19, 2025
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/GCPerfSim/GCPerfSimCommand.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Mar 3, 2025
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/TraceCollection/TraceCollector.cs
Show resolved
Hide resolved
mrsharm
reviewed
Mar 3, 2025
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/TraceCollection/TraceCollector.cs
Outdated
Show resolved
Hide resolved
mrsharm
reviewed
Mar 4, 2025
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/TraceCollection/TraceCollector.cs
Outdated
Show resolved
Hide resolved
…erformance into EnableGCInfraOnLinux
mrsharm
previously approved these changes
Aug 26, 2025
Member
|
TODO: Fix merge conflict. |
auto-merge was automatically disabled
August 26, 2025 02:00
Head branch was pushed to by a user without write access
Member
|
Please update the notebooks, as well. That'll fix the broken build. |
mrsharm
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PerfView only works on Windows, we use dotnet-trace as trace collector on Linux.